Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: OAI_CONFIG_LIST should accept not only .json, but also .yaml #2559

Open
Mai0313 opened this issue May 1, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Mai0313
Copy link
Collaborator

Mai0313 commented May 1, 2024

Is your feature request related to a problem? Please describe.

I am currently working on a project where I aim to make multi-agent experiments more structured. To achieve this, I am integrating the entire workflow and configuration using Hydra by FacebookResearch.

For those familiar with PyTorch Lightning, there is a repository called lightning-hydra-template, which is designed to enhance the experience for fine-tuning and training models.

With this in mind, I believe it would be beneficial to have a function that can load configurations from YAML files. Given that YAML and JSON share similar structures, I anticipate that incorporating this functionality should not pose significant challenges.

Describe the solution you'd like

I have devised a solution that I've successfully tested in my project. In the autogen/oai/openai_utils.py file, I propose replacing json.loads with yaml.safe_load to facilitate the loading of YAML files.

I plan to implement this change and will submit a pull request to address this enhancement.

We can split this or make a new function is ok to me.

Additional context

No response

add yaml support

No tasks being tracked yet.
@ekzhu
Copy link
Collaborator

ekzhu commented May 1, 2024

Is it possible to for us to have both JSON and YAML support?

@Mai0313
Copy link
Collaborator Author

Mai0313 commented May 2, 2024

Is it possible to for us to have both JSON and YAML support?

Yes, i already made a PR
I did this on my own project as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants