Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM2 discontinuity, replace library #2375

Closed
cchampou opened this issue Jul 17, 2023 · 4 comments
Closed

VM2 discontinuity, replace library #2375

cchampou opened this issue Jul 17, 2023 · 4 comments
Labels
feature-request Feature requests in the CLI from users

Comments

@cchampou
Copy link

Is your feature request related to a problem? Please describe.
2 key contributors of this library explain in an issue, that despite their efforts, they won't be able to fix the critical vulnerabilities affecting the lib. That's why they choose to discontinue it, and mark it as deprecated.

Describe the solution you'd like
In this same issue they suggest to migrate to isolated-vm which is allegedly serving the same purpose. Do you think considering migrating to this library is a good option ?

Describe alternatives you've considered
We may just find another package.

Additional context
In case you, as I do, consider migrating is pretty necessary, we may work together to do this migration.

@cchampou cchampou added the feature-request Feature requests in the CLI from users label Jul 17, 2023
@cchampou
Copy link
Author

cchampou commented Jul 17, 2023

Obviously we can also work with proxy-agent to solve this issue at a higher level. Check out this conversation:
TooTallNate/proxy-agents#218

@AnatolyPristensky
Copy link
Contributor

Hello @cchampou, thank you for the information. We've filed an item on our internal dashboard.
Will update this ticket once issue is fixed.

@blumk
Copy link

blumk commented Jul 21, 2023

Latest proxy-agent removed the dependency on vm2.

Manually patching the package.json file with solved the issue.

  "overrides": {
    "appcenter-cli": {
      "proxy-agent": {
        ".": "6.3.0"
      }
    }
  },

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

@AnatolyPristensky
Copy link
Contributor

This issue has been resolved in latest appcenter-cli release. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature requests in the CLI from users
Projects
None yet
Development

No branches or pull requests

3 participants