From 0f753b1c8b3326e85ae245afeadd7b0cd0276ebf Mon Sep 17 00:00:00 2001 From: Sheetal Nandi Date: Tue, 9 Feb 2021 14:33:25 -0800 Subject: [PATCH] Handle if plugin doesnt specify name Fixes microsoft/vscode#116219 --- src/server/project.ts | 4 ++-- src/testRunner/unittests/tsserver/plugins.ts | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/server/project.ts b/src/server/project.ts index 8b857b2651f57..84ea92a4d8d67 100644 --- a/src/server/project.ts +++ b/src/server/project.ts @@ -1474,8 +1474,8 @@ namespace ts.server { protected enablePlugin(pluginConfigEntry: PluginImport, searchPaths: string[], pluginConfigOverrides: Map | undefined) { this.projectService.logger.info(`Enabling plugin ${pluginConfigEntry.name} from candidate paths: ${searchPaths.join(",")}`); - if (parsePackageName(pluginConfigEntry.name).rest) { - this.projectService.logger.info(`kipped loading plugin ${pluginConfigEntry.name} because only package name is allowed plugin name`); + if (!pluginConfigEntry.name || parsePackageName(pluginConfigEntry.name).rest) { + this.projectService.logger.info(`Skipped loading plugin ${pluginConfigEntry.name || JSON.stringify(pluginConfigEntry)} because only package name is allowed plugin name`); return; } diff --git a/src/testRunner/unittests/tsserver/plugins.ts b/src/testRunner/unittests/tsserver/plugins.ts index 4cd692f0576d6..0af8f57e21519 100644 --- a/src/testRunner/unittests/tsserver/plugins.ts +++ b/src/testRunner/unittests/tsserver/plugins.ts @@ -24,7 +24,12 @@ namespace ts.projectSystem { const tsconfig: File = { path: "/tsconfig.json", content: JSON.stringify({ - compilerOptions: { plugins: [...expectedToLoad, ...notToLoad].map(name => ({ name })) } + compilerOptions: { + plugins: [ + ...[...expectedToLoad, ...notToLoad].map(name => ({ name })), + { transform: "some-transform" } + ] + } }) }; const { host, pluginsLoaded } = createHostWithPlugin([aTs, tsconfig, libFile]);