diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 9d089eb7299b0..a8a14dc9b66a5 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -34546,8 +34546,11 @@ namespace ts { : isPropertyAccessExpression(location) ? location.name : isBinaryExpression(location) && isIdentifier(location.right) ? location.right : undefined; + const isPropertyExpressionCast = isPropertyAccessExpression(location) + && isParenthesizedExpression(location.expression) + && isAssertionExpression(location.expression.expression); - if (!testedNode) { + if (!testedNode || isPropertyExpressionCast) { return; } diff --git a/tests/baselines/reference/truthinessCallExpressionCoercion3.js b/tests/baselines/reference/truthinessCallExpressionCoercion3.js new file mode 100644 index 0000000000000..a2ab27f21a2ef --- /dev/null +++ b/tests/baselines/reference/truthinessCallExpressionCoercion3.js @@ -0,0 +1,19 @@ +//// [truthinessCallExpressionCoercion3.ts] +// from #41640, based on an example in ant-design +interface I { + always(): void +} + +function f(result: unknown) { + if ((result as I).always) { + return result + } +} + + +//// [truthinessCallExpressionCoercion3.js] +function f(result) { + if (result.always) { + return result; + } +} diff --git a/tests/baselines/reference/truthinessCallExpressionCoercion3.symbols b/tests/baselines/reference/truthinessCallExpressionCoercion3.symbols new file mode 100644 index 0000000000000..35392c06aef0e --- /dev/null +++ b/tests/baselines/reference/truthinessCallExpressionCoercion3.symbols @@ -0,0 +1,24 @@ +=== tests/cases/compiler/truthinessCallExpressionCoercion3.ts === +// from #41640, based on an example in ant-design +interface I { +>I : Symbol(I, Decl(truthinessCallExpressionCoercion3.ts, 0, 0)) + + always(): void +>always : Symbol(I.always, Decl(truthinessCallExpressionCoercion3.ts, 1, 13)) +} + +function f(result: unknown) { +>f : Symbol(f, Decl(truthinessCallExpressionCoercion3.ts, 3, 1)) +>result : Symbol(result, Decl(truthinessCallExpressionCoercion3.ts, 5, 11)) + + if ((result as I).always) { +>(result as I).always : Symbol(I.always, Decl(truthinessCallExpressionCoercion3.ts, 1, 13)) +>result : Symbol(result, Decl(truthinessCallExpressionCoercion3.ts, 5, 11)) +>I : Symbol(I, Decl(truthinessCallExpressionCoercion3.ts, 0, 0)) +>always : Symbol(I.always, Decl(truthinessCallExpressionCoercion3.ts, 1, 13)) + + return result +>result : Symbol(result, Decl(truthinessCallExpressionCoercion3.ts, 5, 11)) + } +} + diff --git a/tests/baselines/reference/truthinessCallExpressionCoercion3.types b/tests/baselines/reference/truthinessCallExpressionCoercion3.types new file mode 100644 index 0000000000000..200ddbfa13ecc --- /dev/null +++ b/tests/baselines/reference/truthinessCallExpressionCoercion3.types @@ -0,0 +1,23 @@ +=== tests/cases/compiler/truthinessCallExpressionCoercion3.ts === +// from #41640, based on an example in ant-design +interface I { + always(): void +>always : () => void +} + +function f(result: unknown) { +>f : (result: unknown) => unknown +>result : unknown + + if ((result as I).always) { +>(result as I).always : () => void +>(result as I) : I +>result as I : I +>result : unknown +>always : () => void + + return result +>result : unknown + } +} + diff --git a/tests/cases/compiler/truthinessCallExpressionCoercion3.ts b/tests/cases/compiler/truthinessCallExpressionCoercion3.ts new file mode 100644 index 0000000000000..69f6ba8214d40 --- /dev/null +++ b/tests/cases/compiler/truthinessCallExpressionCoercion3.ts @@ -0,0 +1,13 @@ +// @strictNullChecks: true +// @lib: esnext,dom + +// from #41640, based on an example in ant-design +interface I { + always(): void +} + +function f(result: unknown) { + if ((result as I).always) { + return result + } +}