Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOM typescript, mac m1+. #58274

Closed
dvun0g opened this issue Apr 21, 2024 · 13 comments · Fixed by #58398
Closed

OOM typescript, mac m1+. #58274

dvun0g opened this issue Apr 21, 2024 · 13 comments · Fixed by #58398
Assignees
@jakebailey
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@dvun0g
Copy link

dvun0g commented Apr 21, 2024 •
edited

🔎 Search Terms

I tried to find similar typescript OOM in issue github and on the Internet.

🕗 Version & Regression Information

typescript - 5.2.2
macos - macOS Ventura 13.6
chip - Apple M2

This problem appeared with typescript 5+, updating to the latest version of typescript does not prevent the error. Regressing to version 4 of typescript solves this problem. Also, this problem is reproduced only on macs with m1 processor and higher.

⏯ Playground Link

💻 Code

🙁 Actual behavior

Typescript is flowing with OOM errors.

🙂 Expected behavior

Working properly with memory.

Additional information about the issue

I am running eslint on a specific area where the ts/ts files with the react application are located. As a result, the process kills with a memory error - that is, OOM occurs.

Below I provide two snapshots with memory, both to be made after using garbage collector. To see exactly which typescript objects are leaking, it is enough to compare these reports.

Below I attach a link to google drive with snapshot memory. It was not possible to attach this archive directly to the github issue due to the larger file size. - https://drive.google.com/file/d/1XHJCz79eAwBKiHDS2-vtpcR--7b_xF_Z/view?usp=drive_link
@jakebailey
Copy link
Member

If it used to work and now doesn't, consider trying to bisect the problem using https://www.npmjs.com/package/every-ts.

@dimensi
Copy link

dimensi commented Apr 27, 2024 •
edited

Hello @jakebailey , found a problematic commit with bisect. Everything crashes after it.

ff92ab0

ff92ab0ac92b66397bd3b92ff5a3aca3c1ad8f43 is the first bad commit
commit ff92ab0ac92b66397bd3b92ff5a3aca3c1ad8f43
Author: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>
Date:   Fri Jan 20 17:20:26 2023 -0800

    Change default newLine, forceConsistentCasingInFileNames (#52298)
    
    Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
    Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

My OOM crash log

<--- Last few GCs --->

[20242:0x160008000]    18411 ms: Mark-Compact 2043.9 (2087.5) -> 2042.4 (2087.5) MB, 292.33 / 0.00 ms  (average mu = 0.113, current mu = 0.009) allocation failure; scavenge might not succeed
[20242:0x160008000]    18737 ms: Mark-Compact 2044.6 (2087.5) -> 2043.0 (2092.0) MB, 323.21 / 0.00 ms  (average mu = 0.061, current mu = 0.007) allocation failure; scavenge might not succeed


<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0x1023e50e8 node::OOMErrorHandler(char const*, v8::OOMDetails const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 2: 0x10256b120 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 3: 0x10273f668 v8::internal::Heap::GarbageCollectionReasonToString(v8::internal::GarbageCollectionReason) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 4: 0x10274351c v8::internal::Heap::CollectGarbageShared(v8::internal::LocalHeap*, v8::internal::GarbageCollectionReason) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 5: 0x10273ff80 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::internal::GarbageCollectionReason, char const*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 6: 0x10273dd08 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 7: 0x10273d32c v8::internal::Heap::HandleGCRequest() [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 8: 0x1026d5d4c v8::internal::StackGuard::HandleInterrupts() [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 9: 0x102b01a6c v8::internal::Runtime_StackGuardWithGap(int, unsigned long*, v8::internal::Isolate*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
10: 0x102e60c44 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
11: 0x108a247d0
12: 0x108a1fe90
13: 0x108a3307c
14: 0x102e78b3c Builtins_ArrayForEach [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
15: 0x108ac895c
16: 0x108bfa060
17: 0x102e78b3c Builtins_ArrayForEach [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
18: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
19: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
20: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
21: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
22: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
23: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
24: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
25: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
26: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
27: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
28: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
29: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
30: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
31: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
32: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
33: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
34: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
35: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
36: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
37: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
38: 0x102dd83e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
39: 0x102e0f210 Builtins_AsyncFunctionAwaitResolveClosure [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
40: 0x102ebcfb8 Builtins_PromiseFulfillReactionJob [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
41: 0x102dfeb94 Builtins_RunMicrotasks [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
42: 0x102dd63f4 Builtins_JSRunMicrotasksEntry [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
43: 0x1026acae8 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
44: 0x1026acfd4 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
45: 0x1026ad1b0 v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
46: 0x1026d437c v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
47: 0x1026d4b18 v8::internal::MicrotaskQueue::PerformCheckpoint(v8::Isolate*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
48: 0x102308c4c node::InternalCallbackScope::Close() [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
49: 0x102308fe4 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
50: 0x10231ef3c node::AsyncWrap::MakeCallback(v8::Local<v8::Function>, int, v8::Local<v8::Value>*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
51: 0x1023ea520 node::fs::FSReqCallback::Reject(v8::Local<v8::Value>) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
52: 0x1023eadcc node::fs::FSReqAfterScope::Reject(uv_fs_s*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
53: 0x1023eb1dc node::fs::AfterStat(uv_fs_s*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
54: 0x1023d4ad8 node::MakeLibuvRequestCallback<uv_fs_s, void (*)(uv_fs_s*)>::Wrapper(uv_fs_s*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
55: 0x102db2824 uv__work_done [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
56: 0x102db6274 uv__async_io [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
57: 0x102dc834c uv__io_poll [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
58: 0x102db6838 uv_run [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
59: 0x1023096f0 node::SpinEventLoopInternal(node::Environment*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
60: 0x1024249e4 node::NodeMainInstance::Run(node::ExitCode*, node::Environment*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
61: 0x102424764 node::NodeMainInstance::Run() [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
62: 0x1023a3d58 node::Start(int, char**) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
63: 0x19830a0e0 start [/usr/lib/dyld]
[1]    20242 abort      node --max_old_space_size=2048 ./node_modules/.bin/eslint --no-eslintrc

@jakebailey
Copy link
Member

This sounds like #58011 / typescript-eslint/typescript-eslint#1192. Can you provide a codebase which exhibits this problem?

@jakebailey
Copy link
Member

The heap snapshots are somewhat helpful; they continue to point to a blow up due to an incredible number of diagnostics produced by createDiagnosticExplainingFile. 1.5G are just strings like
image

And the memory diff is most definitely the file casing differences.

image

@jakebailey jakebailey mentioned this issue Apr 29, 2024
Closed
@jakebailey
Copy link
Member

Can you try this build? #58352 (comment)

@dimensi
Copy link

dimensi commented Apr 29, 2024

Can you try this build? #58352 (comment)

Some thing

<--- Last few GCs --->

[23756:0x120008000]    21909 ms: Scavenge (reduce) 2045.0 (2084.5) -> 2044.3 (2084.5) MB, 4.04 / 0.00 ms  (average mu = 0.286, current mu = 0.258) allocation failure;
[23756:0x120008000]    22048 ms: Mark-Compact (reduce) 2044.9 (2084.5) -> 2043.7 (2084.8) MB, 90.92 / 0.00 ms  (+ 177.9 ms in 39 steps since start of marking, biggest step 9.8 ms, walltime since start of marking 290 ms) (average mu = 0.278, current mu = 0

<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0x100a450e8 node::OOMErrorHandler(char const*, v8::OOMDetails const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 2: 0x100bcb120 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 3: 0x100d9f668 v8::internal::Heap::GarbageCollectionReasonToString(v8::internal::GarbageCollectionReason) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 4: 0x100da351c v8::internal::Heap::CollectGarbageShared(v8::internal::LocalHeap*, v8::internal::GarbageCollectionReason) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 5: 0x100d9ff80 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::internal::GarbageCollectionReason, char const*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 6: 0x100d9dd08 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 7: 0x100d9495c v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 8: 0x100d951bc v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
 9: 0x100d7a22c v8::internal::Factory::NewFillerObject(int, v8::internal::AllocationAlignment, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
10: 0x101161cf4 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
11: 0x1014c0c44 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
12: 0x1014c13fc Builtins_StringAdd_CheckNone [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
13: 0x10721d098
14: 0x1071ef958
15: 0x1014d8b3c Builtins_ArrayForEach [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
16: 0x107223e1c
17: 0x10718a25c
18: 0x1014d8b3c Builtins_ArrayForEach [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
19: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
20: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
21: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
22: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
23: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
24: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
25: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
26: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
27: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
28: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
29: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
30: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
31: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
32: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
33: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
34: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
35: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
36: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
37: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
38: 0x1014383e4 Builtins_InterpreterEntryTrampoline [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
39: 0x10146f210 Builtins_AsyncFunctionAwaitResolveClosure [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
40: 0x10151cfb8 Builtins_PromiseFulfillReactionJob [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
41: 0x10145eb94 Builtins_RunMicrotasks [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
42: 0x1014363f4 Builtins_JSRunMicrotasksEntry [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
43: 0x100d0cae8 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
44: 0x100d0cfd4 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
45: 0x100d0d1b0 v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
46: 0x100d3437c v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
47: 0x100d34b18 v8::internal::MicrotaskQueue::PerformCheckpoint(v8::Isolate*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
48: 0x100968c4c node::InternalCallbackScope::Close() [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
49: 0x100968fe4 node::InternalMakeCallback(node::Environment*, v8::Local<v8::Object>, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
50: 0x10097ef3c node::AsyncWrap::MakeCallback(v8::Local<v8::Function>, int, v8::Local<v8::Value>*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
51: 0x100a4a520 node::fs::FSReqCallback::Reject(v8::Local<v8::Value>) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
52: 0x100a4adcc node::fs::FSReqAfterScope::Reject(uv_fs_s*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
53: 0x100a4b1dc node::fs::AfterStat(uv_fs_s*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
54: 0x100a34ad8 node::MakeLibuvRequestCallback<uv_fs_s, void (*)(uv_fs_s*)>::Wrapper(uv_fs_s*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
55: 0x101412824 uv__work_done [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
56: 0x101416274 uv__async_io [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
57: 0x10142834c uv__io_poll [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
58: 0x101416838 uv_run [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
59: 0x1009696f0 node::SpinEventLoopInternal(node::Environment*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
60: 0x100a849e4 node::NodeMainInstance::Run(node::ExitCode*, node::Environment*) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
61: 0x100a84764 node::NodeMainInstance::Run() [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
62: 0x100a03d58 node::Start(int, char**) [/Users/n.nafranets/Library/Application Support/fnm/node-versions/v20.12.2/installation/bin/node]
63: 0x19830a0e0 start [/usr/lib/dyld]

@jakebailey
Copy link
Member

Darn, I'll have to stare at the heap dump some more...

@jakebailey jakebailey mentioned this issue Apr 29, 2024
Draft
@jakebailey
Copy link
Member

Another idea that may show something: #58361 (comment)

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Apr 29, 2024
@sheetalkamat
Copy link
Member

Can you please share your code so its easier to debug this than making some assumptions..
There are two potential issues here

  1. one of the eslint plugin is holding onto diagnostics (not 100% sure but i saw this in heapdump)
  2. There are lot of errors generated (we can try to optimize this but we also need to figure out why)

whats the output of tsc --explainFiles on the code that you are running this on.
Does it report errors ? how many?
Again repro would be ideal.

@sheetalkamat sheetalkamat mentioned this issue May 2, 2024
Merged
@sheetalkamat
Copy link
Member

Can you please try #58398 (comment) to see if this fixes your issue.

@dimensi
Copy link

dimensi commented May 3, 2024 •
edited

That seems to have worked 🥹 🎉

@sheetalkamat sheetalkamat linked a pull request May 3, 2024 that will close this issue
Lazy calculation of expensive file explaining diagnsotics and some caching to be used to share the diagnostic data #58398
Merged
@dvun0g
Copy link
Author

dvun0g commented May 6, 2024

Tested the pull request data for our problem.

pr:
#58352
#58361
#58398

With the latest pull request, the OOM problem goes away. Thank you very much for your time and correcting this behavior.

@jakebailey
Copy link
Member

I'm assuming #58398 is what you're saying helped? It includes #58352, but not #58398 (which may or may not actually do anything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakebailey jakebailey

Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Milestone
No milestone
5 participants
@jakebailey @RyanCavanaugh @sheetalkamat @dimensi @dvun0g