[NewErrors] 4.9.0-dev.20221007 vs 4.8.4 #51118

typescript-bot · 2022-10-09T20:09:15Z

The following errors were reported by 4.9.0-dev.20221007, but not by 4.8.4
Pipeline that generated this bug
Logs for the pipeline run
File that generated the pipeline

This run considered 200 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 110 of 200 visited repos

Outcome	Count
Detected interesting changes	14
Detected no interesting changes	96
Git clone failed	2
Package install failed	49
Too many errors in old TS	37
Unknown failure	2

Investigation Status

Repo	Errors	Outcome
ant-design/ant-design	3	Correctly errors on illegal side-cast
codex-team/editor.js	1	Correct error, ref codex-team/editor.js#2131
darkreader/darkreader	8	#51059, by design
Eugeny/tabby	10	By design (checking for wrong property names?)
graphql/graphql-js	1	`expect`ed error is gone now 👍
JedWatson/react-select	1	Correctly errors on possible use of `in` operator on non-object
jupyterlab/jupyterlab	2	node.d.ts conflict
lensapp/lens	10	Correct new errors; ref #51118 (comment)
luin/ioredis	1	`expect`ed error is gone now 👍
react-bootstrap/react-bootstrap	2	Correct new error, probably; ref react-bootstrap/react-bootstrap#6465
reduxjs/reselect	2	#50870
sindresorhus/got	7	Correct error, ref sindresorhus/got#2163
Tencent/vConsole	6	Inference improvement -> contravariant failure
vercel/hyper	1	Simple conflict with node.d.ts

The text was updated successfully, but these errors were encountered:

typescript-bot · 2022-10-09T20:09:16Z

ant-design/ant-design

tsconfig.json

error TS2349: This expression is not callable.
- components/message/tests/config.test.ts#L209
- components/message/tests/config.test.ts#L212
error TS2352: Conversion of type '{ pagination: true; }' to type 'TableProps<any>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- components/table/tests/Table.pagination.test.tsx#L421
error TS2339: Property 'removeAttribute' does not exist on type 'never'.
- tests/setupAfterEnv.ts#L58
- tests/setupAfterEnv.ts#L59

typescript-bot · 2022-10-09T20:09:17Z

codex-team/editor.js

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.build.json

error TS2367: This comparison appears to be unintentional because the types 'PasteConfig' and 'boolean' have no overlap.
- src/components/modules/paste.ts#L287

typescript-bot · 2022-10-09T20:09:17Z

darkreader/darkreader

2 of 6 projects failed to build with the old tsc and were ignored

src/api/tsconfig.json

error TS2339: Property 'getRandomValues' does not exist on type 'never'.
- src/utils/uid.ts#L11
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.
- src/utils/uid.ts#L11

src/tsconfig.json

error TS2339: Property 'getRandomValues' does not exist on type 'never'.
- src/utils/uid.ts#L11
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.
- src/utils/uid.ts#L11

tests/inject/tsconfig.json

error TS2339: Property 'getRandomValues' does not exist on type 'never'.
- src/utils/uid.ts#L11
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.
- src/utils/uid.ts#L11

tests/unit/tsconfig.json

error TS2339: Property 'getRandomValues' does not exist on type 'never'.
- src/utils/uid.ts#L11
error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.
- src/utils/uid.ts#L11

typescript-bot · 2022-10-09T20:09:18Z

Eugeny/tabby

11 of 29 projects failed to build with the old tsc and were ignored

tabby-community-color-schemes/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-electron/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-linkifier/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-local/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-serial/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-ssh/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-telnet/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-terminal/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-terminal/tsconfig.typings.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

tabby-web-demo/tsconfig.json

error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- tabby-terminal/src/api/baseTerminalTab.component.ts#L682

typescript-bot · 2022-10-09T20:09:19Z

graphql/graphql-js

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- src/jsutils/instanceOf.ts#L26

typescript-bot · 2022-10-09T20:09:19Z

JedWatson/react-select

3 of 5 projects failed to build with the old tsc and were ignored

packages/react-select/src/tests/tsconfig.json

error TS2322: Type 'Option | Group' is not assignable to type 'object'.
- packages/react-select/src/Select.tsx#L382

typescript-bot · 2022-10-09T20:09:20Z

jupyterlab/jupyterlab

49 of 56 projects failed to build with the old tsc and were ignored

packages/services/examples/browser/tsconfig.json

error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.
- file:///mnt/ts_downloads/jupyterlab/node_modules/@types/node/globals.d.ts#L114 in packages/coreutils/tsconfig.json
- file:///mnt/ts_downloads/jupyterlab/node_modules/@types/node/globals.d.ts#L114 in packages/statedb/tsconfig.json

packages/services/examples/typescript-browser-with-output/tsconfig.json

error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.
- file:///mnt/ts_downloads/jupyterlab/node_modules/@types/node/globals.d.ts#L114 in packages/coreutils/tsconfig.json
- file:///mnt/ts_downloads/jupyterlab/node_modules/@types/node/globals.d.ts#L114 in packages/statedb/tsconfig.json

typescript-bot · 2022-10-09T20:09:21Z

lensapp/lens

6 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type 'Promise<ReadableStreamReadResult<T>> | Promise<ReadableStreamReadResult<ArrayBufferView>>' is not assignable to type 'Promise<ReadableStreamDefaultReadResult<T>> | undefined'.
- src/common/utils/readableStream.ts#L55
error TS2554: Expected 1 arguments, but got 0.
- src/common/utils/readableStream.ts#L55
error TS18048: 'data' is possibly 'undefined'.
error TS18048: 'data.value' is possibly 'undefined'.
- src/common/utils/readableStream.ts#L64
error TS2322: Type 'RegExpMatchArray | []' is not assignable to type 'RegExpMatchArray'.
- src/renderer/components/dock/logs/store.ts#L215

webpack/tsconfig.json

error TS2322: Type 'Promise<ReadableStreamReadResult<T>> | Promise<ReadableStreamReadResult<ArrayBufferView>>' is not assignable to type 'Promise<ReadableStreamDefaultReadResult<T>> | undefined'.
- src/common/utils/readableStream.ts#L55
error TS2554: Expected 1 arguments, but got 0.
- src/common/utils/readableStream.ts#L55
error TS18048: 'data' is possibly 'undefined'.
error TS18048: 'data.value' is possibly 'undefined'.
- src/common/utils/readableStream.ts#L64
error TS2322: Type 'RegExpMatchArray | []' is not assignable to type 'RegExpMatchArray'.
- src/renderer/components/dock/logs/store.ts#L215

typescript-bot · 2022-10-09T20:09:21Z

luin/ioredis

tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- lib/connectors/SentinelConnector/index.ts#L299

typescript-bot · 2022-10-09T20:09:22Z

react-bootstrap/react-bootstrap

test/tsconfig.json

error TS2345: Argument of type '(Element | ComponentClass<{}, any>) & Record<"setState", unknown>' is not assignable to parameter of type 'ReactInstance | null | undefined'.
- src/safeFindDOMNode.ts#L7

tsconfig.json

error TS2345: Argument of type '(Element | ComponentClass<{}, any>) & Record<"setState", unknown>' is not assignable to parameter of type 'ReactInstance | null | undefined'.
- src/safeFindDOMNode.ts#L7

typescript-bot · 2022-10-09T20:09:23Z

reduxjs/reselect

1 of 3 projects failed to build with the old tsc and were ignored

typescript_test/tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- typescript_test/test.ts#L677
- typescript_test/test.ts#L1621
error TS2345: Argument of type '[{ counter1: number; counter2: number; }, ({} | undefined)?]' is not assignable to parameter of type '[State, (number | undefined)?]'.
- typescript_test/test.ts#L1604

typescript-bot · 2022-10-09T20:09:23Z

sindresorhus/got

tsconfig.json

error TS2322: Type 'boolean' is not assignable to type 'never'.
- source/core/timed-out.ts#L51
error TS2339: Property 'destroy' does not exist on type 'never'.
- source/core/timed-out.ts#L72
error TS2339: Property 'once' does not exist on type 'never'.
- source/core/timed-out.ts#L83
error TS7006: Parameter 'error' implicitly has an 'any' type.
- source/core/timed-out.ts#L83
error TS2339: Property 'listenerCount' does not exist on type 'never'.
- source/core/timed-out.ts#L88
error TS2339: Property 'setTimeout' does not exist on type 'never'.
- source/core/timed-out.ts#L108
error TS2339: Property 'removeListener' does not exist on type 'never'.
- source/core/timed-out.ts#L114

typescript-bot · 2022-10-09T20:09:24Z

Tencent/vConsole

tsconfig.json

error TS2741: Property '0' is missing in type 'string[]' but required in type 'RegExpMatchArray'.
- src/log/system.ts#L52
error TS2339: Property 'apply' does not exist on type 'string extends keyof T ? T[keyof T & string] : any'.
- src/network/fetch.proxy.ts#L36
error TS2322: Type '() => ReadableStreamReader<Uint8Array>' is not assignable to type '{ (options: { mode: "byob"; }): ReadableStreamBYOBReader; (): ReadableStreamDefaultReader<Uint8Array>; (options?: ReadableStreamGetReaderOptions): ReadableStreamReader<...>; }'.
- src/network/fetch.proxy.ts#L60

tsconfig.type.json

error TS2741: Property '0' is missing in type 'string[]' but required in type 'RegExpMatchArray'.
- src/log/system.ts#L52
error TS2339: Property 'apply' does not exist on type 'string extends keyof T ? T[keyof T & string] : any'.
- src/network/fetch.proxy.ts#L36
error TS2322: Type '() => ReadableStreamReader<Uint8Array>' is not assignable to type '{ (options: { mode: "byob"; }): ReadableStreamBYOBReader; (): ReadableStreamDefaultReader<Uint8Array>; (options?: ReadableStreamGetReaderOptions): ReadableStreamReader<...>; }'.
- src/network/fetch.proxy.ts#L60

typescript-bot · 2022-10-09T20:09:25Z

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.
- file:///mnt/ts_downloads/hyper/node_modules/@types/node/globals.d.ts#L72 in app/tsconfig.json

RyanCavanaugh · 2022-10-11T19:43:40Z

ant-design:

  /**
   * `pagination` is not designed to accept `true` value, but in practice, many people assign `true`
   * to `pagination`, since they misunderstand that `pagination` can accept a boolean value.
   */
  it('Accepts pagination as true', () => {
    const { asFragment } = render(createTable({ pagination: true } as TableProps<any>));

This is now flagged as an error - not entirely clear why it wasn't before, but this sort of assertion is I think correctly not supposed to be allowed.

The other errors don't repro on nightly

RyanCavanaugh · 2022-10-11T19:50:15Z

JedWatson/react-select - correctly errors on possible use of in operator on non-object

RyanCavanaugh · 2022-10-11T19:54:36Z

sindresorhus/got - By design. Correct CFA of in operator (based on incorrect type definition) led to downstream code being type-unreachable.

RyanCavanaugh · 2022-10-11T21:10:54Z

lensapp - correct new errors. This code had several deficits relative to the declared input type, which lib updates exposed:

The declared type of reader allowed it to possibly be a ReadableStreamBYOBReader , which has a required view argument to read
The declared type of pendingRead was a little off for some reason
getTimestamps was declared to return a RegExpMatchArray, which always has at least one element, but could actually return [ ]

RyanCavanaugh · 2022-10-11T21:27:04Z

react-bootstrap: Looks like a correct error. Logged react-bootstrap/react-bootstrap#6465

RyanCavanaugh · 2022-10-11T21:43:20Z

All done 💪

RyanCavanaugh added the Committed The team has roadmapped this issue label Oct 11, 2022

RyanCavanaugh closed this as completed Oct 11, 2022

RyanCavanaugh mentioned this issue Oct 17, 2022

[NewErrors] 4.9.0-dev.20221016 vs 4.8.4 #51192

Closed

RyanCavanaugh mentioned this issue Oct 25, 2022

[NewErrors] 4.9.0-dev.20221023 vs 4.8.4 #51281

Closed

[NewErrors] 4.9.0-dev.20221007 vs 4.8.4 #51118

[NewErrors] 4.9.0-dev.20221007 vs 4.8.4 #51118

Comments

typescript-bot commented Oct 9, 2022 • edited by RyanCavanaugh

Investigation Status

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

typescript-bot commented Oct 9, 2022

RyanCavanaugh commented Oct 11, 2022 • edited

RyanCavanaugh commented Oct 11, 2022

RyanCavanaugh commented Oct 11, 2022

RyanCavanaugh commented Oct 11, 2022

RyanCavanaugh commented Oct 11, 2022

RyanCavanaugh commented Oct 11, 2022

typescript-bot commented Oct 9, 2022 •

edited by RyanCavanaugh

RyanCavanaugh commented Oct 11, 2022 •

edited