Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change phrasing for "default property value" diagnostic #45049

Closed
DanielRosenwasser opened this issue Jul 15, 2021 · 3 comments · Fixed by #45052
Closed

Change phrasing for "default property value" diagnostic #45049

DanielRosenwasser opened this issue Jul 15, 2021 · 3 comments · Fixed by #45052
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Milestone

Comments

@DanielRosenwasser
Copy link
Member

In #43005, we added a diagnostic:

"Missing '=' before default property value.

But these aren't default property values - they're initializers. I guess they're "defaults" in the absence of any other values, but that's not really the right term.

I think it should be

"Expected '=' for property initializer.

or

"Missing '=' for property initializer.

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging labels Jul 15, 2021
@DanielRosenwasser
Copy link
Member Author

(@JoshuaKGoldberg in case you're interested)

@DanielRosenwasser DanielRosenwasser added this to the Backlog milestone Jul 15, 2021
@DanielRosenwasser DanielRosenwasser added Good First Issue Well scoped, documented and has the green light Help Wanted You can do this labels Jul 15, 2021
@roottool
Copy link

@DanielRosenwasser I guess Expected '=' for property initializer. is the best. Because I think unified words is better than non-unified words. The some error messages uses Unexpected or expected in #43005.

@JoshuaKGoldberg
Copy link
Contributor

Looks like @a-tarasyuk has got it already 😄 , but thanks - makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants