Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in 'getModuleSpecifierExpression' during 'completionEntryDetails' #41853

Closed
typescript-bot opened this issue Dec 7, 2020 · 10 comments
Closed
Assignees
Labels
Bug A bug in TypeScript Rescheduled This issue was previously scheduled to an earlier milestone Source: Telemetry The issue relates to the telemetry in editors

Comments

@typescript-bot
Copy link
Collaborator

This issue comes from crash dumps in telemetry. We've tried to de-duplicate issues on a best-effort basis, comparing the sequence of methods called and the command requested while ignoring line numbers.
TypeScript version prefix: 4.1.2
VSCode version: 1.52.0-insider
Command requested: completionEntryDetails
Hitting sessions: 155
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:126033:93)
    at compareImportsOrRequireStatements (tsserver.js:126055:78)
    at arrayIsSorted (tsserver.js:878:17)
    at importsAreSorted (tsserver.js:126037:23)
    at insertImports (tsserver.js:114988:65)
    at codeActionForFixWorker (tsserver.js:136442:24)
    at <anonymous> (tsserver.js:136418:24)
    at ChangeTracker.with (tsserver.js:132349:17)
    at codeActionForFix (tsserver.js:136417:60)
    at getImportCompletionAction (tsserver.js:136029:94)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:118335:33)
    at getCompletionEntryDetails (tsserver.js:118299:30)
    at getCompletionEntryDetails (tsserver.js:146723:35)
    at <anonymous> (tsserver.js:157672:57)
    at mapDefined (tsserver.js:610:30)
    at Session.getCompletionEntryDetails (tsserver.js:157670:33)
    at _a.<computed> (tsserver.js:156535:61)
    at <anonymous> (tsserver.js:158276:88)
    at Session.executeWithRequestId (tsserver.js:158267:28)
    at Session.executeCommand (tsserver.js:158276:33)
    at Session.onMessage (tsserver.js:158300:35)
    at <anonymous> (tsserver.js:160510:27)
    at unknown (suppressed.js:223:5)
    at unknown (suppressed.js:315:10)
    at unknown (suppressed.js:460:12)
    at unknown (suppressed.js:172:10)
    at unknown (suppressed.js:223:5)
    at unknown (suppressed.js:309:12)
    at unknown (suppressed.js:290:11)
    at unknown (suppressed.js:224:10)
    at unknown (suppressed.js:181:23)
@typescript-bot typescript-bot added Bug A bug in TypeScript Source: Telemetry The issue relates to the telemetry in editors labels Dec 7, 2020
@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.1.5
VSCode version: 1.53.2
Command requested: completionEntryDetails
Hitting sessions: 3735
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:126035:93)
    at compareImportsOrRequireStatements (tsserver.js:126057:78)
    at arrayIsSorted (tsserver.js:878:17)
    at importsAreSorted (tsserver.js:126039:23)
    at insertImports (tsserver.js:114990:65)
    at codeActionForFixWorker (tsserver.js:136444:24)
    at <anonymous> (tsserver.js:136420:24)
    at ChangeTracker.with (tsserver.js:132351:17)
    at codeActionForFix (tsserver.js:136419:60)
    at getImportCompletionAction (tsserver.js:136031:94)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:118337:33)
    at getCompletionEntryDetails (tsserver.js:118301:30)
    at getCompletionEntryDetails (tsserver.js:146725:35)
    at <anonymous> (tsserver.js:157682:57)
    at mapDefined (tsserver.js:610:30)
    at Session.getCompletionEntryDetails (tsserver.js:157680:33)
    at _a.<computed> (tsserver.js:156545:61)
    at <anonymous> (tsserver.js:158286:88)
    at Session.executeWithRequestId (tsserver.js:158277:28)
    at Session.executeCommand (tsserver.js:158286:33)
    at Session.onMessage (tsserver.js:158310:35)
    at <anonymous> (tsserver.js:160520:27)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:329:10)
    at unknown (suppressed.js:474:12)
    at unknown (suppressed.js:186:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:295:12)
    at unknown (suppressed.js:271:9)
    at unknown (suppressed.js:212:10)
    at unknown (suppressed.js:186:23)

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.2.3
VSCode version: 1.55.0-insider
Command requested: completionEntryDetails
Hitting sessions: 4553
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:127873:93)
    at compareImportsOrRequireStatements (tsserver.js:127895:78)
    at arrayIsSorted (tsserver.js:880:17)
    at importsAreSorted (tsserver.js:127877:23)
    at insertImports (tsserver.js:116625:65)
    at codeActionForFixWorker (tsserver.js:138461:24)
    at <anonymous> (tsserver.js:138437:24)
    at ChangeTracker.with (tsserver.js:134317:17)
    at codeActionForFix (tsserver.js:138436:60)
    at getImportCompletionAction (tsserver.js:138021:94)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:119987:33)
    at getCompletionEntryDetails (tsserver.js:119951:30)
    at getCompletionEntryDetails (tsserver.js:149239:35)
    at unknown (suppressed.js:96:24)
    at <anonymous> (tsserver.js:160359:57)
    at mapDefined (tsserver.js:612:30)
    at Session.getCompletionEntryDetails (tsserver.js:160357:33)
    at _a.<computed> (tsserver.js:159217:61)
    at <anonymous> (tsserver.js:160963:88)
    at Session.executeWithRequestId (tsserver.js:160954:28)
    at Session.executeCommand (tsserver.js:160963:33)
    at Session.onMessage (tsserver.js:160989:35)
    at <anonymous> (tsserver.js:163650:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:329:10)
    at unknown (suppressed.js:474:12)
    at unknown (suppressed.js:186:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:295:12)
    at unknown (suppressed.js:271:9)
    at unknown (suppressed.js:212:10)
    at unknown (suppressed.js:186:23)

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.2.4
VSCode version: 1.56.0-insider
Command requested: completionEntryDetails
Hitting sessions: 184
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:127875:93)
    at compareImportsOrRequireStatements (tsserver.js:127897:78)
    at arrayIsSorted (tsserver.js:880:17)
    at importsAreSorted (tsserver.js:127879:23)
    at insertImports (tsserver.js:116627:65)
    at codeActionForFixWorker (tsserver.js:138463:24)
    at <anonymous> (tsserver.js:138439:24)
    at ChangeTracker.with (tsserver.js:134319:17)
    at codeActionForFix (tsserver.js:138438:60)
    at getImportCompletionAction (tsserver.js:138023:94)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:119989:33)
    at getCompletionEntryDetails (tsserver.js:119953:30)
    at getCompletionEntryDetails (tsserver.js:149239:35)
    at <anonymous> (tsserver.js:160359:57)
    at mapDefined (tsserver.js:612:30)
    at Session.getCompletionEntryDetails (tsserver.js:160357:33)
    at _a.<computed> (tsserver.js:159217:61)
    at <anonymous> (tsserver.js:160963:88)
    at Session.executeWithRequestId (tsserver.js:160954:28)
    at Session.executeCommand (tsserver.js:160963:33)
    at Session.onMessage (tsserver.js:160989:35)
    at <anonymous> (tsserver.js:163650:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:329:10)
    at unknown (suppressed.js:474:12)
    at unknown (suppressed.js:186:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:295:12)
    at unknown (suppressed.js:271:9)
    at unknown (suppressed.js:212:10)
    at unknown (suppressed.js:186:23)

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.3.2
VSCode version: 1.57.0-insider
Command requested: completionEntryDetails
Hitting sessions: 4303
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:131783:93)
    at compareImportsOrRequireStatements (tsserver.js:131805:78)
    at arrayIsSorted (tsserver.js:880:17)
    at importsAreSorted (tsserver.js:131787:23)
    at insertImports (tsserver.js:119830:65)
    at codeActionForFixWorker (tsserver.js:142512:24)
    at <anonymous> (tsserver.js:142488:24)
    at ChangeTracker.with (tsserver.js:138262:17)
    at codeActionForFix (tsserver.js:142487:60)
    at getImportCompletionAction (tsserver.js:141985:98)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:123671:33)
    at getCompletionEntryDetails (tsserver.js:123633:30)
    at getCompletionEntryDetails (tsserver.js:153364:35)
    at <anonymous> (tsserver.js:164587:57)
    at mapDefined (tsserver.js:612:30)
    at Session.getCompletionEntryDetails (tsserver.js:164585:33)
    at _a.<computed> (tsserver.js:163426:61)
    at <anonymous> (tsserver.js:165205:88)
    at Session.executeWithRequestId (tsserver.js:165196:28)
    at Session.executeCommand (tsserver.js:165205:33)
    at Session.onMessage (tsserver.js:165231:35)
    at <anonymous> (tsserver.js:167833:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:337:10)
    at unknown (suppressed.js:482:12)
    at unknown (suppressed.js:194:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:309:12)
    at unknown (suppressed.js:284:9)
    at unknown (suppressed.js:223:10)
    at unknown (suppressed.js:188:23)

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.3.5
VSCode version: 1.58.0
Command requested: completionEntryDetails
Hitting sessions: 4466
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:131788:93)
    at compareImportsOrRequireStatements (tsserver.js:131810:78)
    at arrayIsSorted (tsserver.js:880:17)
    at importsAreSorted (tsserver.js:131792:23)
    at insertImports (tsserver.js:119843:65)
    at codeActionForFixWorker (tsserver.js:142517:24)
    at <anonymous> (tsserver.js:142493:24)
    at ChangeTracker.with (tsserver.js:138267:17)
    at codeActionForFix (tsserver.js:142492:60)
    at getImportCompletionAction (tsserver.js:141990:98)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:123682:33)
    at getCompletionEntryDetails (tsserver.js:123644:30)
    at getCompletionEntryDetails (tsserver.js:153369:35)
    at <anonymous> (tsserver.js:164592:57)
    at mapDefined (tsserver.js:612:30)
    at Session.getCompletionEntryDetails (tsserver.js:164590:33)
    at _a.<computed> (tsserver.js:163431:61)
    at <anonymous> (tsserver.js:165210:88)
    at Session.executeWithRequestId (tsserver.js:165201:28)
    at Session.executeCommand (tsserver.js:165210:33)
    at Session.onMessage (tsserver.js:165236:35)
    at <anonymous> (tsserver.js:167833:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:337:10)
    at unknown (suppressed.js:482:12)
    at unknown (suppressed.js:194:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:309:12)
    at unknown (suppressed.js:284:9)
    at unknown (suppressed.js:223:10)
    at unknown (suppressed.js:188:23)

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.4.2
VSCode version: 1.60.0-insider
Command requested: completionEntryDetails
Hitting sessions: 4843
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:134756:93)
    at compareImportsOrRequireStatements (tsserver.js:134778:78)
    at arrayIsSorted (tsserver.js:884:17)
    at importsAreSorted (tsserver.js:134760:23)
    at insertImports (tsserver.js:122315:65)
    at codeActionForFixWorker (tsserver.js:145719:24)
    at <anonymous> (tsserver.js:145695:24)
    at ChangeTracker.with (tsserver.js:141532:17)
    at codeActionForFix (tsserver.js:145694:60)
    at getImportCompletionAction (tsserver.js:145259:98)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:126511:33)
    at getCompletionEntryDetails (tsserver.js:126468:30)
    at getCompletionEntryDetails (tsserver.js:156791:35)
    at <anonymous> (tsserver.js:168255:57)
    at mapDefined (tsserver.js:616:30)
    at Session.getCompletionEntryDetails (tsserver.js:168253:33)
    at _a.<computed> (tsserver.js:167080:61)
    at <anonymous> (tsserver.js:168873:88)
    at Session.executeWithRequestId (tsserver.js:168864:28)
    at Session.executeCommand (tsserver.js:168873:33)
    at Session.onMessage (tsserver.js:168899:35)
    at <anonymous> (tsserver.js:171504:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:337:10)
    at unknown (suppressed.js:482:12)
    at unknown (suppressed.js:194:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:309:12)
    at unknown (suppressed.js:284:9)
    at unknown (suppressed.js:223:10)
    at unknown (suppressed.js:188:23)

@andrewbranch andrewbranch self-assigned this Sep 7, 2021
@andrewbranch andrewbranch added this to the TypeScript 4.5.1 milestone Sep 7, 2021
@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.4.3
VSCode version: 1.61.0-insider
Command requested: completionEntryDetails
Hitting sessions: 7712
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:134763:93)
    at compareImportsOrRequireStatements (tsserver.js:134785:78)
    at arrayIsSorted (tsserver.js:884:17)
    at importsAreSorted (tsserver.js:134767:23)
    at insertImports (tsserver.js:122319:65)
    at codeActionForFixWorker (tsserver.js:145726:24)
    at <anonymous> (tsserver.js:145702:24)
    at ChangeTracker.with (tsserver.js:141539:17)
    at codeActionForFix (tsserver.js:145701:60)
    at getImportCompletionAction (tsserver.js:145266:98)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:126515:33)
    at getCompletionEntryDetails (tsserver.js:126472:30)
    at getCompletionEntryDetails (tsserver.js:156798:35)
    at <anonymous> (tsserver.js:168262:57)
    at mapDefined (tsserver.js:616:30)
    at Session.getCompletionEntryDetails (tsserver.js:168260:33)
    at _a.<computed> (tsserver.js:167087:61)
    at <anonymous> (tsserver.js:168880:88)
    at Session.executeWithRequestId (tsserver.js:168871:28)
    at Session.executeCommand (tsserver.js:168880:33)
    at Session.onMessage (tsserver.js:168906:35)
    at <anonymous> (tsserver.js:171511:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:337:10)
    at unknown (suppressed.js:482:12)
    at unknown (suppressed.js:194:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:309:12)
    at unknown (suppressed.js:284:9)
    at unknown (suppressed.js:223:10)
    at unknown (suppressed.js:188:23)

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.5.2
VSCode version: 1.63.0-insider
Command requested: completionEntryDetails
Hitting sessions: 124
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:137498:93)
    at compareImportsOrRequireStatements (tsserver.js:137520:78)
    at arrayIsSorted (tsserver.js:887:17)
    at importsAreSorted (tsserver.js:137502:23)
    at insertImports (tsserver.js:124625:65)
    at codeActionForFixWorker (tsserver.js:148904:24)
    at <anonymous> (tsserver.js:148876:24)
    at ChangeTracker.with (tsserver.js:144306:17)
    at codeActionForFix (tsserver.js:148875:60)
    at getImportCompletionAction (tsserver.js:148391:55)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:129141:33)
    at getCompletionEntryDetails (tsserver.js:129085:30)
    at getCompletionEntryDetails (tsserver.js:160045:35)
    at unknown (suppressed.js:2:8377)
    at unknown (suppressed.js:2:8477)
    at <anonymous> (tsserver.js:171540:57)
    at mapDefined (tsserver.js:619:30)
    at Session.getCompletionEntryDetails (tsserver.js:171538:33)
    at _a.<computed> (tsserver.js:170363:61)
    at <anonymous> (tsserver.js:172158:88)
    at Session.executeWithRequestId (tsserver.js:172149:28)
    at Session.executeCommand (tsserver.js:172158:33)
    at Session.onMessage (tsserver.js:172184:35)
    at <anonymous> (tsserver.js:174789:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:337:10)
    at unknown (suppressed.js:482:12)
    at unknown (suppressed.js:194:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:309:12)
    at unknown (suppressed.js:284:9)
    at unknown (suppressed.js:223:10)
    at unknown (suppressed.js:188:23)

@andrewbranch andrewbranch added the Rescheduled This issue was previously scheduled to an earlier milestone label Dec 7, 2021
@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.5.4
VSCode version: 1.63.2
Command requested: completionEntryDetails
Hitting sessions: 4266
Five line hash: d2d934e369ff7c70ebd652a709cf8aaa
Stack:

    at getModuleSpecifierExpression (tsserver.js:137533:93)
    at compareImportsOrRequireStatements (tsserver.js:137555:78)
    at arrayIsSorted (tsserver.js:887:17)
    at importsAreSorted (tsserver.js:137537:23)
    at insertImports (tsserver.js:124644:65)
    at codeActionForFixWorker (tsserver.js:148939:24)
    at <anonymous> (tsserver.js:148911:24)
    at ChangeTracker.with (tsserver.js:144341:17)
    at codeActionForFix (tsserver.js:148910:60)
    at getImportCompletionAction (tsserver.js:148426:55)
    at getCompletionEntryCodeActionsAndSourceDisplay (tsserver.js:129176:33)
    at getCompletionEntryDetails (tsserver.js:129120:30)
    at getCompletionEntryDetails (tsserver.js:160080:35)
    at <anonymous> (tsserver.js:171575:57)
    at mapDefined (tsserver.js:619:30)
    at Session.getCompletionEntryDetails (tsserver.js:171573:33)
    at _a.<computed> (tsserver.js:170398:61)
    at <anonymous> (tsserver.js:172193:88)
    at Session.executeWithRequestId (tsserver.js:172184:28)
    at Session.executeCommand (tsserver.js:172193:33)
    at Session.onMessage (tsserver.js:172219:35)
    at <anonymous> (tsserver.js:174824:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:337:10)
    at unknown (suppressed.js:482:12)
    at unknown (suppressed.js:194:10)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:309:12)
    at unknown (suppressed.js:284:9)
    at unknown (suppressed.js:223:10)
    at unknown (suppressed.js:188:23)

@andrewbranch
Copy link
Member

Fixed by #47433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Rescheduled This issue was previously scheduled to an earlier milestone Source: Telemetry The issue relates to the telemetry in editors
Projects
None yet
Development

No branches or pull requests

3 participants