New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directly using process.argv in typescript.js #33142
Comments
Thanks - this has a PR #33141 open |
Just ran into this when trying to update Deno to 3.6. Looking at the fix available, it still assumes that every runtime with have This fix, IMO, is plastering over the cracks. |
@kitsonk agree. Also, might be better to move this to log in the cli part ( |
Yes, this fix is plastering over the cracks. As I mentioned in the PR, I plastered over the cracks because we’re about to release 3.6.3 and the other people involved were out of town. Knowing it’s not the fix we want, I opened #33246. |
Yeah, I’m also going to need to a proper fix for this in order to integrate TypeScript in miniSphere, which also doesn’t implement Definitely seems like |
TypeScript Version: 3.6.2 (offending code is still in repo when writing this)
Search Terms:
process argv etw
Code
TypeScript/src/compiler/perfLogger.ts
Line 42 in 01e1b1b
Expected behavior:
Should not use process directly.
Actual behavior:
It crashes in hosts which does not have
process
like browsers or any other than nodejs.The text was updated successfully, but these errors were encountered: