Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to Definition does not work for mjs files #28360

Closed
joshunger opened this issue Nov 1, 2018 · 4 comments
Closed

Go to Definition does not work for mjs files #28360

joshunger opened this issue Nov 1, 2018 · 4 comments
Labels
Duplicate An existing issue was already created

Comments

@joshunger
Copy link

Issue Type: Bug

Go to Definition (⌘+Click) does not work for mjs files.

VS Code version: Code - Insiders 1.29.0-insider (4b2fac2b6da220f62ff58b2766e4ecc1f561be94, 2018-10-30T16:46:24.907Z)
OS version: Darwin x64 18.0.0

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.23GB free)
Process Argv .
Screen Reader no
VM 0%
Extensions (16)
Extension Author (truncated) Version
vscode-eslint dba 1.6.1
xml Dot 2.3.2
gitlens eam 8.5.6
EditorConfig Edi 0.12.5
prettier-vscode esb 1.6.1
flow-for-vscode flo 0.8.4
python ms- 2018.9.2
vscode-docker Pet 0.3.1
java red 0.33.0
vscode-fileutils sle 2.11.0
code-spell-checker str 1.6.10
sort-lines Tyr 1.7.0
vscode-java-debug vsc 0.14.0
vscode-java-pack vsc 0.4.0
vscode-java-test vsc 0.10.0
vscode-maven vsc 0.11.1
@mjbvz mjbvz transferred this issue from microsoft/vscode Nov 6, 2018
@mjbvz mjbvz removed their assignment Nov 6, 2018
@microsoft microsoft deleted a comment from vscodebot bot Nov 6, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Nov 6, 2018

Likely falls under #18442 but someone on the TS team will have to verify

@weswigham weswigham added the Duplicate An existing issue was already created label Nov 6, 2018
@weswigham
Copy link
Member

Duplicates #27957. We don't read .mjs files right now.

@robertrossmann
Copy link

I crafted a patch which enables tsserver to recognise, parse and provide type hints for .mjs files.

This might be useful for people who use the .mjs file extensions for JavaScript files with identical module resolution semantics as CommonJS. Note that this patch does not implement any special behaviour with regard to ES modules and might not be spec-compliant. However, editor integrations which allow using custom-built tsserver implementations will greatly increase developer productivity because suddenly everything seems to work.

@typescript-bot
Copy link
Collaborator

This issue has been marked as a duplicate and has seen no activity in the last day. It has been closed for automatic house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

5 participants