diff --git a/src/compiler/sys.ts b/src/compiler/sys.ts index a40034f1bec3a..b2755c4da58b4 100644 --- a/src/compiler/sys.ts +++ b/src/compiler/sys.ts @@ -1217,8 +1217,8 @@ namespace ts { }, getFileSize(path) { try { - const stat = _fs.statSync(path); - if (stat.isFile()) { + const stat = statSync(path); + if (stat?.isFile()) { return stat.size; } } @@ -1265,6 +1265,16 @@ namespace ts { }; return nodeSystem; + /** + * `throwIfNoEntry` was added so recently that it's not in the node types. + * This helper encapsulates the mitigating usage of `any`. + * See https://github.com/nodejs/node/pull/33716 + */ + function statSync(path: string): import("fs").Stats | undefined { + // throwIfNoEntry will be ignored by older versions of node + return (_fs as any).statSync(path, { throwIfNoEntry: false }); + } + /** * Uses the builtin inspector APIs to capture a CPU profile * See https://nodejs.org/api/inspector.html#inspector_example_usage for details @@ -1323,7 +1333,7 @@ namespace ts { activeSession.post("Profiler.stop", (err, { profile }) => { if (!err) { try { - if (_fs.statSync(profilePath).isDirectory()) { + if (statSync(profilePath)?.isDirectory()) { profilePath = _path.join(profilePath, `${(new Date()).toISOString().replace(/:/g, "-")}+P${process.pid}.cpuprofile`); } } @@ -1613,7 +1623,10 @@ namespace ts { const name = combinePaths(path, entry); try { - stat = _fs.statSync(name); + stat = statSync(name); + if (!stat) { + continue; + } } catch (e) { continue; @@ -1645,7 +1658,10 @@ namespace ts { function fileSystemEntryExists(path: string, entryKind: FileSystemEntryKind): boolean { try { - const stat = _fs.statSync(path); + const stat = statSync(path); + if (!stat) { + return false; + } switch (entryKind) { case FileSystemEntryKind.File: return stat.isFile(); case FileSystemEntryKind.Directory: return stat.isDirectory(); @@ -1680,7 +1696,7 @@ namespace ts { function getModifiedTime(path: string) { try { - return _fs.statSync(path).mtime; + return statSync(path)?.mtime; } catch (e) { return undefined; diff --git a/src/tsserver/server.ts b/src/tsserver/server.ts index 36f7869b4f1d4..fc6325c8637f1 100644 --- a/src/tsserver/server.ts +++ b/src/tsserver/server.ts @@ -679,6 +679,7 @@ namespace ts.server { return { getModifiedTime, poll, startWatchTimer, addFile, removeFile }; function getModifiedTime(fileName: string): Date { + // Caller guarantees that `fileName` exists, so there'd be no benefit from throwIfNoEntry return fs.statSync(fileName).mtime; }