From 0990c31c4b45a81035b40d64adf54c0cc29eedfd Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 4 Jan 2022 15:48:45 -0800 Subject: [PATCH] Refactor test, add new (failing) test for dotted with a desirable snippet completion --- .../jsxTagNameDottedAttributeSnippet.ts | 33 +++++++++++++++++++ .../fourslash/jsxTagNameDottedNoSnippet.ts | 10 +++--- 2 files changed, 38 insertions(+), 5 deletions(-) create mode 100644 tests/cases/fourslash/jsxTagNameDottedAttributeSnippet.ts diff --git a/tests/cases/fourslash/jsxTagNameDottedAttributeSnippet.ts b/tests/cases/fourslash/jsxTagNameDottedAttributeSnippet.ts new file mode 100644 index 0000000000000..f1b717ba0d8f6 --- /dev/null +++ b/tests/cases/fourslash/jsxTagNameDottedAttributeSnippet.ts @@ -0,0 +1,33 @@ +/// +//@Filename: file.tsx +////interface NestedInterface { +//// Foo: NestedInterface; +//// (props: {className?: string}): any; +////} +//// +////declare const Foo: NestedInterface; +//// +////function fn1() { +//// return +//// +////} +////function fn2() { +//// return +//// +////} + +verify.completions( + { + marker: test.markers(), + includes: [ + { name: "className", insertText: 'className={$1}', isSnippet: true, sortText: completion.SortText.OptionalMember } + ], + preferences: { + jsxAttributeCompletionStyle: "braces", + includeCompletionsWithSnippetText: true, + includeCompletionsWithInsertText: true, + }, + } +) diff --git a/tests/cases/fourslash/jsxTagNameDottedNoSnippet.ts b/tests/cases/fourslash/jsxTagNameDottedNoSnippet.ts index 46ecb3d9c1d88..6b9b589a1bf41 100644 --- a/tests/cases/fourslash/jsxTagNameDottedNoSnippet.ts +++ b/tests/cases/fourslash/jsxTagNameDottedNoSnippet.ts @@ -38,9 +38,9 @@ //// ////} -for (const marker of test.markers()) { - verify.completions({ - marker, +verify.completions( + { + marker: test.markers(), includes: [ { name: "Foo", insertText: undefined, isSnippet: undefined } ], @@ -49,5 +49,5 @@ for (const marker of test.markers()) { includeCompletionsWithSnippetText: true, includeCompletionsWithInsertText: true, }, - }) -} + } +)