Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix popup styling for Sublime Text 4xxx (backwards compatible) #758

Closed
wants to merge 1 commit into from
Closed

Fix popup styling for Sublime Text 4xxx (backwards compatible) #758

wants to merge 1 commit into from

Conversation

ephemer
Copy link

@ephemer ephemer commented Sep 22, 2020 •
edited

Fixes #755 by accessing keys of the style object more safely.
Backwards compatible with any version of Sublime Text using Python 3+

@ephemer ephemer mentioned this pull request Sep 22, 2020
Open
@rgant
Copy link
Contributor

rgant commented Oct 19, 2020

Duplicate of #757

@orta
Copy link
Contributor

orta commented Dec 7, 2020

I can't tell if this was fixed upstream in ST4 because I couldn't reproduce the original bug on a build I've just downloaded (4094)

That said, I'm confirming that this still works on both ST3 and ST4, which could be enough anyway?

Screen Shot 2020-12-07 at 12 39 10 PM
Screen Shot 2020-12-07 at 12 38 58 PM

@orta
Copy link
Contributor

orta commented Dec 7, 2020

That said, I think we should go for #757 which also has the validity check, so I'm going to close this out

@orta orta closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashed in Sublime build 4084
3 participants
@ephemer @rgant @orta