Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending load message to the embed control should reset the snapshot list #604

Open
mscherotter opened this issue Jan 27, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mscherotter
Copy link

mscherotter commented Jan 27, 2023

Snapshots don't work if the data set is different, so when the snapshot list is not reset when a new data set and insight is loaded, the snapshots fail to load correctly.
Recommend resetting snapshots when load message is received and data changes.

@danmarshall danmarshall added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 27, 2023
@danmarshall
Copy link
Contributor

Snapshots can refer to DataFile objects via url, such that a list of snapshots can load the dataset to which it is bound. Perhaps we should add a flag to the load command to clear the snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants