Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in plotting of 1d datasets using plot dataset #5196

Open
jenshnielsen opened this issue Jun 6, 2023 · 1 comment
Open

Regression in plotting of 1d datasets using plot dataset #5196

jenshnielsen opened this issue Jun 6, 2023 · 1 comment

Comments

@jenshnielsen
Copy link
Collaborator

Consider the example here https://qcodes.github.io/Qcodes/examples/Parameters/Simple-Example-of-ParameterWithSetpoints.html#Measurement before qcodes 0.25 this used to be plotted as a line plot but in 0.26.0 onwards this is now plotted as a scatter plot.

Some debugging indicate that this is because the setpoints and probably also data has gained an extra singleton dimension this means that np.all_close in datatype_from_setpoints_1d will always return True since [[1,2,3,...]] and [1,2,3,...] are always identical due to broadcasting.

@jenshnielsen
Copy link
Collaborator Author

This looks like a bug in #3024

Bisect gives us

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
4e85af2
dbca907
663ed26
7f92e33
26f687f
We cannot bisect more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant