Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC: Recent commits break compilation #1147

Open
diamante0018 opened this issue Feb 27, 2024 · 0 comments
Open

MSVC: Recent commits break compilation #1147

diamante0018 opened this issue Feb 27, 2024 · 0 comments

Comments

@diamante0018
Copy link

Hello, I'm afraid one of the most recent commits has broken on MSVC as it now triggers some warnings.

The following does remind me a lot of the first issue I opened on this repo some time ago as it too was an issue with the MSVC preprocessor and the min/max macros. Maybe this is similar?

Dear maintainers, please consider adding an MSVC workflow that tests this repo. I only see one for Android and Ubuntu (Linux)

Error: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\util(44,40): error C[22](https://github.com/diamante0018/DisablePlutoChat/actions/runs/8058374482/job/22011065160#step:6:23)20: the following warning is treated as an error [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')
  
Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\util(44,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')
  
Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\util(163,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')
  
Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\span(67,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')
  
Warning: D:\a\DisablePlutoChat\DisablePlutoChat\deps\GSL\include\gsl\span(855,40): warning C4067: unexpected tokens following preprocessor directive - expected a newline [D:\a\DisablePlutoChat\DisablePlutoChat\build\common.vcxproj]
  (compiling source file '../src/common/utils/thread.cpp')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant