Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless check against dynamic_extent #1029

Merged
merged 2 commits into from Apr 28, 2022
Merged

Remove useless check against dynamic_extent #1029

merged 2 commits into from Apr 28, 2022

Conversation

dmitrykobets-msft
Copy link
Member

Addresses #1013

sunnychatterjee
sunnychatterjee approved these changes Apr 27, 2022
View reviewed changes
Copy link

@sunnychatterjee sunnychatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dmitry and I walked through the code and this change looks reasonable to me. We'll follow up with Casey for another round of review and then merge.

CaseyCarter
CaseyCarter approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I agree with Dmitry's analysis in #1013.

@dmitrykobets-msft dmitrykobets-msft merged commit da01eb2 into microsoft:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@sunnychatterjee sunnychatterjee sunnychatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmitrykobets-msft @CaseyCarter @sunnychatterjee