Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcelink support for core #1760

Closed
ssa3512 opened this issue Apr 6, 2020 · 3 comments
Closed

Add sourcelink support for core #1760

ssa3512 opened this issue Apr 6, 2020 · 3 comments

Comments

@ssa3512
Copy link

ssa3512 commented Apr 6, 2020

I am attempting to troubleshoot issues with custom telemetry correlation and it is difficult to step into the app insights library to identify what is going wrong. It would be helpful if the core library (Microsoft.ApplicationInsights) supported sourcelink. This is already supported on the netcore logging library here:

<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>

@TimothyMothra
Copy link
Member

note to self: estimate the work, see if we can take this in 2.15

@TimothyMothra
Copy link
Member

We'll need to follow this general guidance to onboard:
https://github.com/dotnet/sourcelink#using-source-link-in-net-projects

@TimothyMothra
Copy link
Member

SourceLink has been turned on and will be available in our next 2.15 beta release. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants