Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.ApplicationInsights.WorkerService depends on Microsoft.Extensions.DependencyInjection 2.2 instead of 2.1 #1677

Closed
czb182 opened this issue Feb 12, 2020 · 4 comments
Milestone

Comments

@czb182
Copy link

czb182 commented Feb 12, 2020

I noticed that the Microsoft.ApplicationInsights.WorkerService nuget package has a dependency on Microsoft.Extensions.DependencyInjection version 2.2.0. I see Microsoft.ApplicationInsights.WorkerService being advertising for Asp.Net.Core 2.1+ in documentation so seems like it should depend on Microsoft.Extensions.DependencyInjection 2.1.*.

I asked on dotnet repo about matching .NET core version against asp.net/extensions and they said it should match, which is why im bringing this up.
dotnet/extensions#2799

@TimothyMothra
Copy link
Member

Thank you for bringing this to our attention.
I'll take a look at it and see if we can downgrade the version.

@eddynaka
Copy link
Contributor

@cijothomas / @TimothyMothra , I was looking at this issue. I saw that we have some references to DependencyInjection 2.2 in 3 projects:

  • TelemetryChannel.Tests
  • Ilogger.NetStandard.Tests
  • ApplicationInsights.WorkerService

To solve this issue, we would have to downgrade at least to 2.1.0 or 2.1.1. What do you think?

With this, we would be able to accept netcoreapp 2.1, 2.2 and 3.*

Let me know!

Thank you

@TimothyMothra
Copy link
Member

@eddynaka feel free to start a [WIP] PR (work in progress) with this change.
We'll be looking for tests to validate that this change doesn't impact functionality so please think about how to test this change against the different target frameworks.
If you can verify that we already have test coverage I think that would be sufficient.

@eddynaka
Copy link
Contributor

Sure!

To test the WorkerService, I was thinking in creating 3 projects, plug the dlls and check in ApplicationInsights the collected data.

Doing that before the change and after the change. The results have to be the same.

I will check our current automatic tests and see if they keep working as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants