Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD doesn't publish artifacts in custom branches #951

Open
cegekaJG opened this issue Feb 22, 2024 · 2 comments
Open

CI/CD doesn't publish artifacts in custom branches #951

cegekaJG opened this issue Feb 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@cegekaJG
Copy link
Contributor

One of our repos is now running CI/CD for a secondary branch, but I noticed that the CI/CD workflows from this branch aren't creating any artifacts of the compiled apps, even though they encounter no errors and the default branch publishes its apps just fine.

Here's the Build log from the default (main) branch:
logs_36.zip

And here's the Build log from the second (testmaster) branch:
logs_37.zip

Both branches have the same AL Go system files. This behavior is consistent with a different repository using the same settings and branching structure. I know I have "doNotPublishApps" enabled, but that never stopped the apps on main being published.

@freddydk
Copy link
Contributor

Currently, artifacts are being created for the main branch, for release branches and when it is detected that there are deliveryTargets or DeploymentTargets, controlled by this line in CI/CD:

publishArtifacts: ${{ github.ref_name == 'main' || startswith(github.ref_name, 'release/') || startswith(github.ref_name, 'releases/') || needs.Initialization.outputs.deliveryTargetsJson != '[]' || needs.Initialization.outputs.environmentCount > 0 }}

We did earlier discuss always publishing artifacts and maybe that is a better choice.

@cegekaJG
Copy link
Contributor Author

At the very least, being able to define custom glob or regex patterns for this would be extremely useful - we have a couple client-agnostic apps in their own repository, and since they are only accessed using "appDependencyProbingPaths", there's no need to define environments of delivery targets.

@freddydk freddydk added the enhancement New feature or request label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants