Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kotlin-extension-functions to the documentation #78

Closed
sdelamo opened this issue May 25, 2020 · 10 comments
Closed

Add kotlin-extension-functions to the documentation #78

sdelamo opened this issue May 25, 2020 · 10 comments
Assignees

Comments

@sdelamo
Copy link
Contributor

sdelamo commented May 25, 2020

No description provided.

@willbuck
Copy link
Contributor

@sdelamo Just wanting to be clear, here; we do have the extension functions documented (in brief) here

Is this meant to get the full dokka documentation (of all extension functions) available as well?

If so, I am nearly done with that, and will create a PR shortly. I will probably want to update the GH action slightly to rename a file that gets generated (unless I am able to chat with the Dokka devs to figure out how to do it via the gradle config; I have requested access to the kotlin slack)

@willbuck willbuck self-assigned this Nov 12, 2020
willbuck added a commit that referenced this issue Nov 12, 2020
@willbuck
Copy link
Contributor

willbuck commented Nov 12, 2020

So it looks like dokka has some kind of likely memory leak that makes actually building the docs a bit tricky.

See this issue for more info / updates: Kotlin/dokka#1405

Also something going on with this issue: Kotlin/dokka#537

So @sdelamo and @jameskleeh we could modify the github action for the release to add --no-parallel --no-daemon -Dorg.gradle.jvmargs="-XX:MaxMetaspaceSize=1g" to the gradlew docs portion, and that should successfully run everything, but I can totally understand why we wouldn't want to do that for every project template, and we can wait on Dokka to figure out the memory issue instead.

Thoughts?

@willbuck
Copy link
Contributor

willbuck commented Mar 8, 2021

Root cause seems to be this:

Kotlin/kotlinx.coroutines#2558

dokka crew has said this will be partially fixed with 1.4.30 release of dokka but coroutines fix needed for it to be fully eliminated.

Is there a way we can commit the docs built on my machine to the gh-pages branch and have them stay there through rebuilds until that fix comes?

@ilopmar
Copy link
Contributor

ilopmar commented Mar 10, 2021

@willbuck you can modify the workflow to adapt it to what this project needs. We have a few workflows modified in some projects like GCP or Kubernetes. The only thing to keep in mind is that we can't automatically merge the "common files updates" PRs, but it's not a big deal.

Regarding the docs. You can generate the docs locally, checkout the gh-pages, copy there the updated version of the docs (keep in mind not only the a.b.x directory but also latest), commit and push the gh-pages branch.

Let me know if you need help or have any additional questions.

@willbuck
Copy link
Contributor

@ilopmar I was thinking of doing the "push straight to gh-pages" but was concerned it would be overwritten by future builds, is that not the case?

I think I would just need to update https://github.com/micronaut-projects/micronaut-kotlin/blob/master/.github/workflows/gradle.yml and hopefully the other files could still merge automatically, is there a particular way I could make future merges as smooth as possible (only add to the end?)

@ilopmar
Copy link
Contributor

ilopmar commented Mar 10, 2021

@ilopmar I was thinking of doing the "push straight to gh-pages" but was concerned it would be overwritten by future builds, is that not the case?

Yes, it will be overwritten when we do a new release.

I think I would just need to update https://github.com/micronaut-projects/micronaut-kotlin/blob/master/.github/workflows/gradle.yml and hopefully the other files could still merge automatically, is there a particular way I could make future merges as smooth as possible (only add to the end?)

Yeah, that's the workflow you need to modify: https://github.com/micronaut-projects/micronaut-kotlin/blob/master/.github/workflows/gradle.yml#L47

As you are only going to modify the one line it won't be too much complicated to merge the changes in the future. Don't worry :-)

@sdelamo
Copy link
Contributor Author

sdelamo commented Mar 27, 2021

can this be closed @willbuck ?

@willbuck
Copy link
Contributor

@sdelamo not quite yet, need to fix the build, didn't get a chance yesterday. Think it's a resource issue

@sdelamo
Copy link
Contributor Author

sdelamo commented Aug 30, 2023

@timyates review if this issue should still be open or can be closed.

@sdelamo sdelamo assigned timyates and unassigned willbuck Aug 30, 2023
@timyates
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants