Skip to content

Disable prediction and distribution for test-suite-kotlin #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

timyates
Copy link
Contributor

We were seeing strange behaviour if one of the test-suite-kotlin tests failed

After checking with the Gradle team, they said:

The issue seems to be due to the tests in test-suite-kotlin being run with Test Distribution. Unfortunately we don't support Kotest for Test Distribution for the time being.
We have added a check to detect such cases in Gradle Enterprise 3.11.2, which means that from that version onwards, your build will fail with an explicit error message. Therefore we would recommend you to disable Test Distribution and Predictive Test Selection for test-suite-kotlin, to avoid any issues once you update Gradle Enterprise.

This change should disable test-distribution and predictive tests for the test-suite-kotlin module

@timyates timyates added the relates-to: build label for issues related to the build file or CI label Jan 16, 2023
@timyates timyates requested review from melix and sdelamo January 16, 2023 15:11
@timyates timyates self-assigned this Jan 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo
Copy link
Contributor

sdelamo commented Jan 18, 2023

@melix ping

@sdelamo sdelamo merged commit b5d405c into 3.8.x Jan 19, 2023
@sdelamo sdelamo deleted the disable-prediction-and-distribution branch January 19, 2023 18:56
timyates added a commit to micronaut-projects/micronaut-test that referenced this pull request Apr 20, 2023
This version of Kotest supports Predictive Tests (so we can undo micronaut-projects/micronaut-core#8612)

It requires Kotlin 1.8+ but I believe for 4.0.0 this is ok
sdelamo pushed a commit to micronaut-projects/micronaut-test that referenced this pull request Apr 20, 2023
* Upgrade to Kotest 5.6.0

This version of Kotest supports Predictive Tests (so we can undo micronaut-projects/micronaut-core#8612)

It requires Kotlin 1.8+ but I believe for 4.0.0 this is ok

* 5.6.1 is the latest today
timyates added a commit that referenced this pull request Apr 21, 2023
We had to disable Predictive Test Selection and Test Distribution for Kotest tests as Kotest was unsupported.

As of micronaut-test-4.0.0-M2, we use a supported version of Kotest 5, so this pr reverses

#8612

To re-enable these Gradle features
timyates added a commit that referenced this pull request Apr 24, 2023
We had to disable Predictive Test Selection and Test Distribution for Kotest tests as Kotest was unsupported.

As of micronaut-test-4.0.0-M2, we use a supported version of Kotest 5, so this pr reverses

#8612

To re-enable these Gradle features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates-to: build label for issues related to the build file or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants