Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BeanProvider's find method #7133

Merged
merged 1 commit into from Apr 1, 2022
Merged

Fix BeanProvider's find method #7133

merged 1 commit into from Apr 1, 2022

Conversation

Paullo612
Copy link
Contributor

Fixes #7132

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@sdelamo sdelamo added this to the 3.4.1 milestone Mar 23, 2022
@Paullo612
Copy link
Contributor Author

Looks like get(Qualifier<Object> qualifier) is also affected. It ignores Qualifier specified on provider injection point:

micronaut-core/inject/src/main/java/io/micronaut/inject/provider/BeanProviderDefinition.java

Lines 82 to 84 in cd60651

public Object get(Qualifier<Object> qualifier) {
return ((DefaultBeanContext) context).getBean(resolutionContext, argument, qualifier);
}

I could also fix that in this merge request, but wouldn't it be a breaking change?

May I force push, or it would be better to do another commit?

By the way, something went wrong with SonarCube:
image

@sdelamo sdelamo modified the milestones: 3.4.1, 3.4.2 Mar 30, 2022
@graemerocher graemerocher merged commit 316b90e into micronaut-projects:3.4.x Apr 1, 2022
@Paullo612 Paullo612 mentioned this pull request Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.

BeanProvider's find method ignores passed qualifier
4 participants
@Paullo612 @CLAassistant @graemerocher @sdelamo