Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle void return type from Function clients #6771

Merged
merged 1 commit into from Jan 18, 2022
Merged

Handle void return type from Function clients #6771

merged 1 commit into from Jan 18, 2022

Conversation

timyates
Copy link
Member

Calling a client method with a void return type failed with a NullPointerException when
we tried to make the request.

This change checks for a void return type and instead calls exchange if it is found

@timyates timyates added the type: bug Something isn't working label Jan 18, 2022
@timyates timyates added this to the 3.2.7 milestone Jan 18, 2022
@timyates timyates self-assigned this Jan 18, 2022
@timyates timyates linked an issue Jan 18, 2022 that may be closed by this pull request
Return void from function client's method causes exception #2024
Closed
@jameskleeh jameskleeh merged commit ffe26cd into 3.2.x Jan 18, 2022
@jameskleeh jameskleeh deleted the client-function-void-return branch January 18, 2022 16:03
yawkat pushed a commit that referenced this pull request Jan 21, 2022
@timyates @yawkat
Handle void return type from Function clients (#6771)
944db35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

@jameskleeh jameskleeh Awaiting requested review from jameskleeh

Assignees

@timyates timyates

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.2.7
Development

Successfully merging this pull request may close these issues.

Return void from function client's method causes exception
3 participants
@timyates @graemerocher @jameskleeh