Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ExecuteOn(TaskExecutors.IO) does not work with @ServerWebSocket #10758

Closed
munishchouhan opened this issue Apr 23, 2024 · 0 comments · Fixed by #10772
Closed

@ExecuteOn(TaskExecutors.IO) does not work with @ServerWebSocket #10758

munishchouhan opened this issue Apr 23, 2024 · 0 comments · Fixed by #10772
Assignees

Comments

@munishchouhan
Copy link

munishchouhan commented Apr 23, 2024

Expected Behavior

I am trying to run my websocket on IO threads, but its still running on default Netty event loop group

Actual Behaviour

It should run on IO threads

Steps To Reproduce

you can check the code here
seqeralabs/wave#471

Environment Information

OS: Mac 14.4.1 (23E224)

Example Application

seqeralabs/wave#471

Version

3.10.3

jeremyg484 added a commit that referenced this issue Apr 27, 2024
NettyServerWebSocketHandler is updated to check for the ExecuteOn
annotation when invoking any of the callback methods on a
ServerWebSocket annotated class, and to use the specified
ExecutorService when invoking the methods.

A test is added to verify the enhanced behavior.

This resolves #10758
jeremyg484 added a commit that referenced this issue May 2, 2024
NettyServerWebSocketHandler is updated to check for the ExecuteOn
annotation when invoking any of the callback methods on a
ServerWebSocket annotated class, and to use the specified
ExecutorService when invoking the methods.

A test is added to verify the enhanced behavior.

This resolves #10758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants