Injecting HTTP Client into TypedArgumentBinder results in StackOverflowError

[musketyr]

Expected Behavior

Developer should be able to depend on any bean that is either a HTTP client or injects HTTP client transitively when creating TypedArgumentBinder

Actual Behaviour

When TypedArgumentBinder even transitively depends on any HTTP client then the application won't start at all.

Steps To Reproduce

Use the repo below for reproducer with branch cannot-depend-on-client-from-binder and run FactsControllerTest

1. create new application with controller method accepting injecting some POJO e.g. CatFact
2. create HTTP client that fetches the POJO from some REST API, e.g. https://cat-fact.herokuapp.com
3. create TypedRequestArgumentBinder that is responsible for injecting the POJO
4. run the application

Environment Information

JDK 21 Zulu

Example Application

https://github.com/musketyr/micronaut-blocking-calls-in-binders-issue/tree/cannot-depend-on-client-from-binder

Version

4.4.0

[sdelamo]

I am unsure about this. I don't think the API TypedArgumentBinder was thought for users to do network requests inside them. I think that logic would be best in a controller method.

[musketyr]

at least there should be some sensible warning. it took quite a long time to figure out in the tree of beans what is causing the issues. ideally it should suggest the workaround using Provider<BeanUsingHttpClient>

[yawkat]

The reproducer is private, can you please make it public

[musketyr]

@yawkat done!