Micronaut Netty client handler "micronaut-http-response" not available when customizing channel pipeline for logbook handler

[subash89]

I am trying to add logbook client handler using NettyClientCustomizer.Registry bean listener as per micronaut docs.
But getting following error. Reason is by the time I am suppose to register my handler, ChannelPipelineCustomizer.HANDLER_MICRONAUT_HTTP_RESPONSE not available. Any suggestions to fix this ?

  @Override
        public void onStreamPipelineBuilt() {
            channel.pipeline().addBefore(
                    ChannelPipelineCustomizer.HANDLER_MICRONAUT_HTTP_RESPONSE,
                    "logbook-client",
                    new LogbookClientHandler(logbook)
            );
        }

java.util.NoSuchElementException: micronaut-http-response
	at io.netty.channel.DefaultChannelPipeline.getContextOrDie(DefaultChannelPipeline.java:1073)
	at io.netty.channel.DefaultChannelPipeline.addBefore(DefaultChannelPipeline.java:248)
	at io.netty.channel.DefaultChannelPipeline.addBefore(DefaultChannelPipeline.java:237)
	at com.test.logging.logbook.LogbookClientCustomizer$Customizer.onStreamPipelineBuilt(LogbookClientCustomizer.java:75)
	at io.micronaut.http.netty.AbstractCompositeCustomizer.forEach(AbstractCompositeCustomizer.java:109)
	at io.micronaut.http.client.netty.CompositeNettyClientCustomizer.onStreamPipelineBuilt(CompositeNettyClientCustomizer.java:57)
	at io.micronaut.http.client.netty.ConnectionManager$Pool$Http2ConnectionHolder.init(ConnectionManager.java:1366)
	at io.micronaut.http.client.netty.ConnectionManager$4.channelRead(ConnectionManager.java:622)

[yawkat]

same as #10514

[yawkat]

you can use a filter with @Body, but it will mean buffering the body fully all the time

[subash89]

The main reason is the loggings and obfuscations logbook provides. Can you explain a bit more why logbook support stop working with http2 ? And any alternative for logbook functionality will be provided ?

[yawkat]

as of (probably) 4.5.0, the http2 stack will not use per-stream pipelines anymore, and will not use intermediate http1 objects on the pipeline. This is for performance reasons. Both of these things were necessary for the logbook netty integration.

It will be necessary to build a logbook integration based on filters. Maybe it would be worthwhile to build a dedicated micronaut-logbook module for this use case.

[subash89]

I tried using @Body in the server filter. I could read (@Body String ) in @RequestFilter. But in Server @ResponseFilter, I cannot inject @Body. only option was to do something like response.getBody() in my method. But in here this getting response filter engaged before response getting serialized. response.getBody actually returns my json model PoJo class. What should I do to read response body as a String.

[subash89]

@yawkat the question is more like on Response path, is there a way I can access to the serialized(String) version of the response body. I tried lowest precedence for my response server filter method, but still when I do response.getBody() it still has the Json PoJo object.