Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[control-panel-ui] Provide a default "card" for custom health indicators details #61

Open
LeBezout opened this issue Oct 11, 2023 · 1 comment
Labels
type: improvement A minor improvement to an existing feature

Comments

@LeBezout
Copy link

Feature description

If in our app we implements some custom health indicators and if we go to the /control-panel/health detail page, this failed to display.

Actual Behaviour

  "_embedded": {
    "errors": [
      {
        "message": "Internal Server Error: Error rendering Handlebars view [layout]: /views/health/detail.hbs:17:29: The partial '/(stringFormat \"views/health/%s\" (cut @key '()')).hbs' at '/views/health/MyCustomIndicator.hbs' could not be found"
      }
    ]
  },
  "message": "Internal Server Error"

Steps To Reproduce

  1. Implements a io.micronaut.management.health.indicator.HealthIndicator
  2. Start app and launch /control-panel/health page
  3. You can see an "Internal Server Error" message

Expected Behavior

If the view is not found display a default message like "No information available" in a card titled with the indicator name.

@alvarosanchez
Copy link
Member

Related to #59

@alvarosanchez alvarosanchez added the type: improvement A minor improvement to an existing feature label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants