Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for @MeterTag to @Counted #4725

Open
ColdFireIce opened this issue Feb 5, 2024 · 2 comments · May be fixed by #4958
Open

Add Support for @MeterTag to @Counted #4725

ColdFireIce opened this issue Feb 5, 2024 · 2 comments · May be fixed by #4958
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with module: micrometer-core An issue that is related to our core module
Milestone
1.14.0-M1

Comments

@ColdFireIce
Copy link

Hi there,

I would like to count method calls with an enum in the parameters and use these as tags for the counter. Something analogue to to the @timed annotation.
It would be super to have the option to add an MeterAnnotationHandler to the CountedAspect, as you can for the TimedAspect.

I'm not sure if this needs more explanation or an example?

Best regards
@shakuzen shakuzen added enhancement A general enhancement module: micrometer-core An issue that is related to our core module and removed waiting-for-triage labels Feb 6, 2024
@shakuzen shakuzen added this to the 1.x milestone Feb 6, 2024
@shakuzen shakuzen added the help wanted An issue that a contributor can help us with label Feb 6, 2024
@shakuzen
Copy link
Member

shakuzen commented Feb 6, 2024

Thanks for the enhancement request. I think it makes sense to bring CountedAspect support up to the level of TimedAspect with respect to @MeterTag. Is this something you'd be willing to submit a pull request for?

izeye added a commit to izeye/micrometer that referenced this issue Apr 10, 2024
@izeye
Support @MeterTag for @counted
627fdd0 
Closes micrometer-metricsgh-4725
@izeye izeye linked a pull request Apr 10, 2024 that will close this issue
Open
@izeye
Copy link
Contributor

izeye commented Apr 10, 2024

I created #4958 to try to resolve this.

@shakuzen shakuzen modified the milestones: 1.x, 1.14.0-M1 Apr 16, 2024
@izeye izeye mentioned this issue May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.14.0-M1
Development

Successfully merging a pull request may close this issue.

Support @MeterTag for @Counted izeye/micrometer
3 participants
@izeye @ColdFireIce @shakuzen