Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to target classes and not only methods with TimedAspect #493

Closed
davidkarlsen opened this issue Mar 14, 2018 · 1 comment · Fixed by #1279
Closed

Be able to target classes and not only methods with TimedAspect #493

davidkarlsen opened this issue Mar 14, 2018 · 1 comment · Fixed by #1279
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Projects
Aspect epic
Milestone
1.9.0-M4

Comments

@davidkarlsen
Copy link
Contributor

See discussion in https://micrometer-metrics.slack.com/archives/C662HUJC9/p1521063013000264
Suggest to make the aspect target also types (in addition to methods), so that by annotating a class, you target all public methods in that class too (due to the way spring works it does not target private/default/protected scopes).
@davidkarlsen davidkarlsen changed the title TimedAspect improvement #1 TimedAspect improvement #1 - be able to target classes and not only methods Mar 14, 2018
@jkschneider jkschneider added this to the 1.1.0 milestone Mar 14, 2018
@jkschneider
Copy link
Contributor

Related to #500

@jkschneider jkschneider modified the milestones: 1.1.0-rc.1, 1.1.0-rc.2 Oct 13, 2018
@jkschneider jkschneider modified the milestones: 1.1.0-rc.2, 1.1.0, 1.x Oct 21, 2018
@jonatan-ivanov jonatan-ivanov mentioned this issue Mar 2, 2021
Closed
@shakuzen shakuzen added this to To do in Aspect epic Mar 24, 2021
@shakuzen shakuzen modified the milestones: 1.x, 1.9.0-M4 Mar 4, 2022
@shakuzen shakuzen added enhancement A general enhancement module: micrometer-core An issue that is related to our core module labels Mar 4, 2022
@shakuzen shakuzen changed the title TimedAspect improvement #1 - be able to target classes and not only methods Be able to target classes and not only methods with TimedAspect Mar 4, 2022
@shakuzen shakuzen mentioned this issue Mar 4, 2022
Closed
@shakuzen shakuzen linked a pull request Mar 17, 2022 that will close this issue
Time method calls within a class when class is annotated with @Timed #1279
Merged
@shakuzen shakuzen mentioned this issue Mar 17, 2022
Merged
Aspect epic automation moved this from To do to Done Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Projects
Aspect epic
Done
Milestone
1.9.0-M4
Development

Successfully merging a pull request may close this issue.

Time method calls within a class when class is annotated with @Timed sabouri/micrometer
3 participants
@davidkarlsen @jkschneider @shakuzen