Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing PrometheusConfig#prometheusProperties from "get" #4922

Open
shakuzen opened this issue Apr 5, 2024 · 0 comments
Open

Support parsing PrometheusConfig#prometheusProperties from "get" #4922

shakuzen opened this issue Apr 5, 2024 · 0 comments
Labels
enhancement A general enhancement registry: prometheus A Prometheus Registry related issue
Milestone
1.13.x

Comments

@shakuzen
Copy link
Member

shakuzen commented Apr 5, 2024 

          I wonder if we should try parsing from `get` to populate the default Properties. See, for example, what we do in `OtlpConfig#resourceAttributes`. This would allow Micrometer users to use this with e.g. a `.properties` file and implementing only `get`.

Originally posted by @shakuzen in #4921 (comment)
@shakuzen shakuzen added enhancement A general enhancement registry: prometheus A Prometheus Registry related issue labels Apr 5, 2024
@shakuzen shakuzen added this to the 1.13.x milestone Apr 5, 2024
@shakuzen shakuzen mentioned this issue Apr 5, 2024
Merged
@jonatan-ivanov jonatan-ivanov mentioned this issue Apr 5, 2024
Closed
@jonatan-ivanov jonatan-ivanov changed the title Support parsing PrometheusConfig#prometheusProperties from get Support parsing PrometheusConfig#prometheusProperties from "get" Apr 5, 2024
@jonatan-ivanov jonatan-ivanov mentioned this issue Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement registry: prometheus A Prometheus Registry related issue
Projects
None yet
Milestone
1.13.x
Development

No branches or pull requests
1 participant
@shakuzen