Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Prometheus registry onMeterRegistrationFailed callback #4622

Closed
shakuzen opened this issue Jun 16, 2021 · 3 comments
Closed

Document Prometheus registry onMeterRegistrationFailed callback #4622

shakuzen opened this issue Jun 16, 2021 · 3 comments
Labels
doc-update A documentation update registry: prometheus A Prometheus Registry related issue
Milestone

Comments

@shakuzen
Copy link
Member

This is exactly what happened. I'm an app using micrometer + some custom registry to micrometer + prometheus.
I spent a few hours trying to figure out why some metrics don't appear after adding prometheus.
I think it would be better to make this behaviour configurable.

Originally posted by @angry-cellophane in #2400 (comment)

@shakuzen
Copy link
Member Author

First, sorry for the frustration and time spent due to the current behavior, @angry-cellophane. We need to do a better job documenting this, so I've made this issue to track that.

I think it would be better to make this behaviour configurable.

For what it's worth, the behavior is configurable. You can restore the previous behavior of an exception being thrown and an error logged with the throwExceptionOnRegistrationFailure method on the PrometheusMeterRegistry.

@shakuzen shakuzen transferred this issue from micrometer-metrics/micrometer-docs Jan 30, 2024
@shakuzen shakuzen added doc-update A documentation update registry: prometheus A Prometheus Registry related issue labels Jan 30, 2024
@shakuzen shakuzen added this to the 1.12.x milestone Jan 30, 2024
izeye added a commit to izeye/micrometer that referenced this issue Mar 31, 2024
@izeye
Copy link
Contributor

izeye commented Mar 31, 2024

I created #4878 to try to resolve this.

shakuzen pushed a commit that referenced this issue Apr 1, 2024
@shakuzen
Copy link
Member Author

shakuzen commented Apr 1, 2024

Thanks so much, @izeye.
Closed by #4878

@shakuzen shakuzen closed this as completed Apr 1, 2024
@shakuzen shakuzen modified the milestones: 1.12.x, 1.12.5 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-update A documentation update registry: prometheus A Prometheus Registry related issue
Projects
None yet
Development

No branches or pull requests

2 participants