Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observation "granularity" #3442

Open
jonatan-ivanov opened this issue Sep 28, 2022 · 3 comments · May be fixed by #4613
Open

Observation "granularity" #3442

jonatan-ivanov opened this issue Sep 28, 2022 · 3 comments · May be fixed by #4613
Labels
enhancement A general enhancement waiting for team An issue we need members of the team to review

Comments

@jonatan-ivanov
Copy link
Member

We received some feedback from users who instrument components that in some cases it would be useful to conditionally create Observations based on configuration. Something similar to log levels, e.g.: let's say we have two "levels" BASIC and DETAILED, if the config is set to DETAILED/ALL, all observations are created, if the config is set to BASIC, only those Observations are created that have BASIC as their level and DETAILED goes to noop.

/cc @jzheaux
@jonatan-ivanov jonatan-ivanov added waiting for feedback We need additional information before we can continue waiting for team An issue we need members of the team to review labels Sep 28, 2022
@jonatan-ivanov jonatan-ivanov mentioned this issue Feb 10, 2023
Closed
@marcingrzejszczak marcingrzejszczak added enhancement A general enhancement and removed waiting for feedback We need additional information before we can continue labels Dec 20, 2023
marcingrzejszczak added a commit that referenced this issue Jan 25, 2024
@marcingrzejszczak
Adds Observation Granularity
20f6a56 
- introduces observation levels (same as in logging)
- extends the current API to allow passing of ObservationLevel

fixes gh-3442
@marcingrzejszczak marcingrzejszczak linked a pull request Jan 25, 2024 that will close this issue
Draft
marcingrzejszczak added a commit that referenced this issue Jan 25, 2024
@marcingrzejszczak
Adds Observation Granularity
ca74473 
- introduces observation levels (same as in logging)
- extends the current API to allow passing of ObservationLevel

fixes gh-3442
marcingrzejszczak added a commit that referenced this issue Jan 25, 2024
@marcingrzejszczak
Adds Observation Granularity
d144742 
- introduces observation levels (same as in logging)
- extends the current API to allow passing of ObservationLevel

fixes gh-3442
@jonatan-ivanov
Copy link
Member Author

jonatan-ivanov commented Jan 30, 2024 •
edited

We had some discussions internally, what do you think about having these levels: OFF, BASIC, DETAILED, FULL? (OFF would not make sense from instrumentation perspective but only for filtering by the end-users)
Or would you prefer two levels instead of three during instrumentation, like: OFF, BASIC, DETAILED?

@bclozel, @jzheaux, @ttddyy, @mhalbritter @marcingrzejszczak

@ttddyy
Copy link
Contributor

ttddyy commented Jan 31, 2024

So, if I map them to logging level, would FULL=trace, DETAILED=debug, BASIC=info appropriate?

For JDBC instrumentation, I have connection, query, and result-set observations, all of which I believe fall into BASIC.
For Spring Security, it seems that most observations would align with the DETAILED level.
As for Boot/Framework observations, they would likely be BASIC.

I wonder what would be the best fit for FULL level observation if we have it.

@mhalbritter
Copy link

I'm fine with the 4 levels. FULL would give implementors, like @ttddyy said, a "trace" level if needed.

marcingrzejszczak added a commit that referenced this issue Feb 7, 2024
@marcingrzejszczak
Adds Observation Granularity
d223632 
- introduces observation levels (same as in logging)
- extends the current API to allow passing of ObservationLevel

fixes gh-3442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement waiting for team An issue we need members of the team to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds Observation Granularity micrometer-metrics/micrometer
4 participants
@ttddyy @jonatan-ivanov @marcingrzejszczak @mhalbritter