Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Observed Tomcat Valve #3777

Open
marcingrzejszczak opened this issue Apr 20, 2023 · 4 comments · May be fixed by #3989
Open

Add Observed Tomcat Valve #3777

marcingrzejszczak opened this issue Apr 20, 2023 · 4 comments · May be fixed by #3989
Labels
enhancement A general enhancement

Comments

@marcingrzejszczak
Copy link
Contributor

Example here https://github.com/micrometer-metrics/micrometer-samples/blob/4f9a6cd9d1c12fa19ec79a49766cce6afccd5ce2/micrometer-samples-boot3-web/src/main/java/io/micrometer/boot3/samples/web/ManualConfiguration.java#L41-L96
@marcingrzejszczak marcingrzejszczak added the enhancement A general enhancement label Apr 20, 2023
@bclozel bclozel mentioned this issue Oct 2, 2023
Closed
@bclozel bclozel mentioned this issue Nov 9, 2023
Closed
@marcingrzejszczak marcingrzejszczak linked a pull request Dec 20, 2023 that will close this issue
Added Jakarta and Javax instrumentations #3989
Open
@fischermatte
Copy link

fischermatte commented Feb 21, 2024 •
edited

@marcingrzejszczak Do you have a solution to this?

@jonatan-ivanov
Copy link
Member

What are you seeking a solution for?
Have you checked the code in the description of this PR?

@fischermatte
Copy link

Sry, maybe I misunderstood something. I am coming from this issue (Exceptions are not logged with span-id/trace-id with latest spring boot). There @bclozel mentioned this

"You can follow #3777 if you'd like to instrument your application at a lower level with Tomcat."

Now it looks like this PR is still open for some reason. Do you see any chance that exceptions logged from tomcat itself can be enhanced with a trace-id/span-id?

@marcingrzejszczak
Copy link
Contributor Author

Tomcat valve instrumentation is done here - #3989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Jakarta and Javax instrumentations micrometer-metrics/micrometer
3 participants
@fischermatte @jonatan-ivanov @marcingrzejszczak