Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullable to Observation.parentObservation #3532

Merged
merged 1 commit into from Nov 13, 2022
Merged

Add nullable to Observation.parentObservation #3532

merged 1 commit into from Nov 13, 2022

Conversation

ttddyy
Copy link
Contributor

@ttddyy ttddyy commented Nov 13, 2022

No description provided.

@marcingrzejszczak marcingrzejszczak merged commit 83279b6 into micrometer-metrics:main Nov 13, 2022
@ttddyy ttddyy deleted the parent-obs-nullable branch November 13, 2022 20:07
@shakuzen
Copy link
Member

I think this should have been targeted at 1.10.x so it goes in the next patch release. It seems more like a bug that we missed this than a new feature.

shakuzen pushed a commit that referenced this pull request Nov 14, 2022
@ttddyy @shakuzen
Add nullable to Observation.parentObservation (#3532)
7f42bb7
@shakuzen
Copy link
Member

I've cherry-picked it to 1.10.x in 7f42bb7

@shakuzen shakuzen added this to the 1.10.1 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug A general bug module: micrometer-observation
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttddyy @shakuzen @marcingrzejszczak