Migrate tests from TagsTest to KeyValuesTest #3525
Merged
+360
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also resolves some discrepancies between KeyValues and Tags that have been spotted by the tests. Closes micrometer-metricsgh-3502
shakuzen
approved these changes
Nov 7, 2022
shakuzen
added
module: micrometer-common
shakuzen
removed
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the tests from the
TagsTestto theKeyValuesTest.This PR also resolves some discrepancies between the
KeyValuesand theTagsthat have been spotted by the tests.Closes gh-3502