Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a default for missing values in KeyValue #3458

Closed
jonatan-ivanov opened this issue Oct 6, 2022 · 0 comments
Closed

Provide a default for missing values in KeyValue #3458

jonatan-ivanov opened this issue Oct 6, 2022 · 0 comments
Labels
enhancement A general enhancement
Milestone
1.10.0-RC1

Comments

@jonatan-ivanov
Copy link
Member

Right now there is no guidance about what to do when a value is missing and users want to create a KeyValue.
@jonatan-ivanov jonatan-ivanov added the enhancement A general enhancement label Oct 6, 2022
@jonatan-ivanov jonatan-ivanov added this to the 1.10.0-RC1 milestone Oct 6, 2022
jonatan-ivanov added a commit that referenced this issue Oct 6, 2022
@jonatan-ivanov
Rename NONE to NONE_VALUE in KeyValue
8ae84dd 
related gh-3458
izeye added a commit to izeye/micrometer that referenced this issue Oct 18, 2022
@izeye
Add KeyValue.of() variants for none values
1a12ce7 
See micrometer-metricsgh-3458
@izeye izeye mentioned this issue Oct 18, 2022
Closed
izeye added a commit to izeye/spring-framework that referenced this issue Oct 18, 2022
@izeye
Use KeyValue.NONE_VALUE where possible
d905124 
See micrometer-metrics/micrometer#3458
@izeye izeye mentioned this issue Oct 18, 2022
Closed
bclozel pushed a commit to spring-projects/spring-framework that referenced this issue Oct 19, 2022
@izeye @bclozel
Use KeyValue.NONE_VALUE where possible
5dca43e 
See micrometer-metrics/micrometer#3458

Closes gh-29342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.10.0-RC1
Development

No branches or pull requests
1 participant
@jonatan-ivanov