Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestObservationRegistryAssert assertion for observation count #3426

Closed
bclozel opened this issue Sep 23, 2022 · 0 comments · Fixed by #3432
Closed

Add TestObservationRegistryAssert assertion for observation count #3426

bclozel opened this issue Sep 23, 2022 · 0 comments · Fixed by #3432
Labels
enhancement A general enhancement module: micrometer-observation-test
Milestone
1.10.0-RC1

Comments

@bclozel
Copy link
Contributor

bclozel commented Sep 23, 2022

Currently TestObservationRegistryAssert offers several assertion method for checking observations on an individual basis.
I would like to check for the number of observations for a given observation name. This can be useful when checking that retries support records several observations, or that filters prevent cardinality explosion in metrics.

It seems that the tracing test support already offers a hasNumberOfSpansWithNameEqualTo.
@shakuzen shakuzen added this to the 1.10 backlog milestone Sep 26, 2022
@marcingrzejszczak marcingrzejszczak modified the milestones: 1.10 backlog, 1.10.0-RC1 Sep 26, 2022
marcingrzejszczak added a commit that referenced this issue Sep 26, 2022
@marcingrzejszczak
Added more assertions for TestObservationRegistry
f6ab8fd 
fixes gh-3426
@marcingrzejszczak marcingrzejszczak mentioned this issue Sep 26, 2022
Merged
marcingrzejszczak added a commit that referenced this issue Sep 26, 2022
@marcingrzejszczak
Added more assertions for TestObservationRegistry (#3432)
bd0d8e9 
fixes gh-3426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement module: micrometer-observation-test
Projects
None yet
Milestone
1.10.0-RC1
Development

Successfully merging a pull request may close this issue.

Added more assertions for TestObservationRegistry micrometer-metrics/micrometer
3 participants
@bclozel @marcingrzejszczak @shakuzen