Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTLP resource service name is always unknown #3146

Closed
shakuzen opened this issue Apr 28, 2022 · 0 comments · Fixed by #3159
Closed

OTLP resource service name is always unknown #3146

shakuzen opened this issue Apr 28, 2022 · 0 comments · Fixed by #3159
Labels
bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Milestone
1.9.0

Comments

@shakuzen
Copy link
Member

We should provide a way for the service.name to be configured. The simplest way would be a configuration option that passes through as is. There is a preference to aim for something more portable, though, since other registries may not have an explicit concept of service.name but would benefit from one being configured and consistent with the service.name publish in OTLP format.

Originally posted by @shakuzen in #3129 (comment)
@shakuzen shakuzen added bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related labels Apr 28, 2022
@shakuzen shakuzen added this to the 1.9.0 milestone Apr 28, 2022
@shakuzen shakuzen mentioned this issue May 11, 2022
Merged
@jonatan-ivanov jonatan-ivanov linked a pull request May 11, 2022 that will close this issue
Config for OTLP Resource attributes #3159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Config for OTLP Resource attributes shakuzen/micrometer
2 participants
@jonatan-ivanov @shakuzen