Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LongTaskTimer always converts durations of measurements to nanos #2947

Closed
jonatan-ivanov opened this issue Jan 7, 2022 · 0 comments · Fixed by #2948
Closed

LongTaskTimer always converts durations of measurements to nanos #2947

jonatan-ivanov opened this issue Jan 7, 2022 · 0 comments · Fixed by #2948
Assignees
@jonatan-ivanov
Labels
bug A general bug module: micrometer-core An issue that is related to our core module
Milestone
1.7.8

Comments

@jonatan-ivanov
Copy link
Member

If you call the measure method of LongTaskTimer and check the duration, it's always in nanoseconds instead of the baseUnit.
@jonatan-ivanov jonatan-ivanov added the bug A general bug label Jan 7, 2022
@jonatan-ivanov jonatan-ivanov added this to the 1.7.8 milestone Jan 7, 2022
@jonatan-ivanov jonatan-ivanov self-assigned this Jan 7, 2022
jonatan-ivanov added a commit to jonatan-ivanov/micrometer that referenced this issue Jan 7, 2022
@jonatan-ivanov
Fix duration conversion of LongTaskTimer
dcc515f 
If you call the measure method of LongTaskTimer and check the duration, it's always in nanoseconds instead of the baseUnit.
It seems the original intention was using the base unit: micrometer-metrics@70925b3#diff-551e65260957b90931b406fcb647b39367c83d11aa8f07d3f388c667d60f8971R124
fixes micrometer-metricsgh-2947
@jonatan-ivanov jonatan-ivanov mentioned this issue Jan 7, 2022
Merged
@jonatan-ivanov jonatan-ivanov added the module: micrometer-core An issue that is related to our core module label Jan 7, 2022
@rsynek rsynek mentioned this issue Jan 18, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonatan-ivanov jonatan-ivanov

Labels
bug A general bug module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.7.8
Development

Successfully merging a pull request may close this issue.

Fix duration conversion of LongTaskTimer jonatan-ivanov/micrometer
1 participant
@jonatan-ivanov