Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against NPE in MongoMetricsConnectionPoolListener #2454

Merged
merged 1 commit into from Feb 17, 2021

Conversation

shakuzen
Copy link
Member

Logically, the other events should not happen after the connection pool has been closed, but it seems they sometimes do. When they do (e.g. on shutdown), a NPE was being thrown. This change guards against such NPEs.

Resolves gh-2384

Logically, the other events should not happen after the connection pool has been closed, but it seems they sometimes do. When they do (e.g. on shutdown), a NPE was being thrown. This change guards against such NPEs.

Resolves micrometer-metricsgh-2384
@shakuzen shakuzen merged commit 3b6e727 into micrometer-metrics:1.3.x Feb 17, 2021
@shakuzen shakuzen deleted the mongo-cp-listener-npe branch February 17, 2021 02:00
@jshields-squarespace
Copy link
Contributor

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants