Clean up compile warnings in 1.3.x branch #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
the
polish
shakuzen
approved these changes
Dec 3, 2019
| @@ -39,7 +39,7 @@ | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| import static com.github.tomakehurst.wiremock.client.WireMock.*; | |||
| import static org.assertj.core.api.Java6Assertions.assertThat; | |||
There was a problem hiding this comment.
I wonder if we shouldn't ban this import. Is there a reason for us being Java 8 base to ever use the Java6Assertions package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up compile warnings in the 1.3.x branch.