From fc2bae081955c20873961eae03730a6a74d9e009 Mon Sep 17 00:00:00 2001
From: Tommy Ludwig <8924140+shakuzen@users.noreply.github.com>
Date: Thu, 14 Oct 2021 03:17:25 +0900
Subject: [PATCH] Deprecate ReactorNettySender (#2814)

Having code in micrometer-core that depends on reactor-netty creates a dependency cycle between the two projects. In an effort to work towards eliminating that cycle, we are proactively deprecating the ReactorNettySender. If we receive feedback that users have use cases for it, we can consider moving it to the reactor-netty project or elsewhere. Lacking enough feedback, we will plan to remove this in the next feature release.

See gh-2802
---
 .../java/io/micrometer/core/ipc/http/ReactorNettySender.java    | 2 ++
 .../io/micrometer/core/ipc/http/ReactorNettySenderTests.java    | 1 +
 2 files changed, 3 insertions(+)

diff --git a/micrometer-core/src/main/java/io/micrometer/core/ipc/http/ReactorNettySender.java b/micrometer-core/src/main/java/io/micrometer/core/ipc/http/ReactorNettySender.java
index 07ce71fdff..4a6cdb710e 100644
--- a/micrometer-core/src/main/java/io/micrometer/core/ipc/http/ReactorNettySender.java
+++ b/micrometer-core/src/main/java/io/micrometer/core/ipc/http/ReactorNettySender.java
@@ -25,7 +25,9 @@
  *
  * @author Jon Schneider
  * @since 1.1.0
+ * @deprecated use a different {@link HttpSender} implementation or report your use case for this to the Micrometer project maintainers
  */
+@Deprecated
 public class ReactorNettySender implements HttpSender {
     private final HttpClient httpClient;
 
diff --git a/micrometer-core/src/test/java/io/micrometer/core/ipc/http/ReactorNettySenderTests.java b/micrometer-core/src/test/java/io/micrometer/core/ipc/http/ReactorNettySenderTests.java
index 1b3911dee1..cc640872ac 100644
--- a/micrometer-core/src/test/java/io/micrometer/core/ipc/http/ReactorNettySenderTests.java
+++ b/micrometer-core/src/test/java/io/micrometer/core/ipc/http/ReactorNettySenderTests.java
@@ -29,6 +29,7 @@
 import static com.github.tomakehurst.wiremock.client.WireMock.*;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 
+@SuppressWarnings("deprecation")
 @ExtendWith(WiremockResolver.class)
 class ReactorNettySenderTests {
     HttpSender httpSender = new ReactorNettySender();