-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong dependency version for picomatch #196
Comments
Only create one issue, on one repository. |
And which repository do you think is a better fit for this? |
I'm really not sure, but it seems like fast-glob is a good start, since the breakage is happening there. We all collaborate often, and I'd be happy to help debug. FWIW, when you create the same issue on multiple repositories (specifically, before figuring out exactly what the issue is), you end up creating a scenario where no one knows who is tackling the issue or spending there time debugging, and no one wants to duplicate efforts. |
I understand your initial reaction, creating issues in multiple repos probably isn't very helpful in most circumstances. However, I think I've done my homework good and every repo is aware of what might be going wrong and who is responsible for it. I've come here from graphql-code-generator -> globby -> fast-glob -> micromatch -> picomatch, debugging every layer and interaction between deps with multiple versions, finally nailed down the exact problem. You see, the problem doesn't occur with every version combination. It's basically about luck how yarn/npm hoists dependencies which depends on a lot of factors such as the state of Reported to each repo with the source of regression; so that users/library maintainers using any of them don't spend as much time as I did. Just glad that |
Fair enough, that makes sense, and given the amount of time and attention you've given this, it seems I was hasty in my assumptions. I appreciate it, thank you. |
Release in 4.0.3 |
micromatch
has a dependency ofpicomatch@^2.0.5
.Using the below code snippet with various matching
picomatch
versions:Results:
So, shouldn't the dependency be
picomatch@^2.2.0
?Regression downstream:
mrmlnc/fast-glob#253
Or is
parts
a private API ofmicromatch
?The text was updated successfully, but these errors were encountered: