Skip to content

metascraper-author: remove invalid markup support #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Mar 8, 2021

I re-download the HTML markup related to the integration tests.

some interesting thing:

  • just the verge still has wrong markup (tweet).
  • the washington post doesn't have markup (tweet).

Verified

This commit was signed with the committer’s verified signature.
Kikobeats Kiko Beats
I refetched the HTML markup related with the integration tests we have there.

Just The Verge has the wrong markup

https://twitter.com/Kikobeats/status/1368961061274214400
@Kikobeats Kikobeats marked this pull request as ready for review March 8, 2021 17:34
@Kikobeats Kikobeats merged commit 8036930 into master Mar 8, 2021
@Kikobeats Kikobeats deleted the author branch March 8, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant