feat(audio/video): add support for ld+json contentUrl property #355
+325
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @Kikobeats! |
|
shipped at Also, available at Microlink API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by @goleary
closes #353
Adds support for extracting audio/video URLs from the contentUrl property in
ld+json.I have not come across a page that uses this for video urls (perhaps because I haven't been looking) but I decided to go ahead and add support for video too since the schema.org docs call out:
I should probably figure out how to write my own integration tests at some point huh @Kikobeats. Feel free to add them yourself or point me in the right direction and I can do it myself.
Here are the URLs I was using to test: