Skip to content

Breaking regression: url-regex-safe removed but is still required #317

Closed
@rynop

Description

@rynop

Prerequisites

  • I'm using the last version.
    My node version is the same as declared as package.json.

Subject of the issue

Error: Cannot find module 'url-regex-safe'

Steps to reproduce

install version 5.14.16

55a7809#diff-5fa62491fdc784b119f866e62f2fa57622727b91416ddaff5e40d65066be95b3R24 you will see url-regex-safe was removed as a dependency in favor of url-regex HOWEVER the old url-regex-safe is still being required: require('url-regex-safe')...

Activity

changed the title [-]Bug: `url-regex-safe` removed but is still `require`d, breaking this package[/-] [+]Breaking regression: `url-regex-safe` removed but is still `require`d, breaking this package[/+] on Oct 14, 2020
changed the title [-]Breaking regression: `url-regex-safe` removed but is still `require`d, breaking this package[/-] [+]Breaking regression: `url-regex-safe` removed but is still `require`d[/+] on Oct 14, 2020
Kikobeats

Kikobeats commented on Oct 14, 2020

@Kikobeats
Member

Thanks! A new patch release is coming 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @rynop@Kikobeats

        Issue actions

          Breaking regression: `url-regex-safe` removed but is still `require`d · Issue #317 · microlinkhq/metascraper