fix(metascrapper-date): chrono as default date parser fix #241 #244
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavaGanzin
changed the title
slavaGanzin
force-pushed
the
chrono-sync
branch
from
2abb597 to
c80ed58
Compare
Kikobeats
reviewed
Dec 12, 2019
| // try to parse a complex date string | ||
| const parsed = chrono.parseDate(value) | ||
| const parsed = chrono.parseDate(value, new Date(''), { forwardDate: true }) // magick |
There was a problem hiding this comment.
@slavaGanzin can you explain why these additional parameters are necessary? I don't understand it 🙂
There was a problem hiding this comment.
mainly because
> new Date('')
Invalid Date
There was a problem hiding this comment.
@Kikobeats I'm not sure why it works, but it was the only way I can get from chrono to convert any date without year to current year. Because in publishing if year is not specified it means "this year". TechCrunch and Substack, for example, do so
But chrono make some bogus assumptions:
SyntaxError: Unexpected identifier
> require('chrono-node').parseDate('Jan 20')
2020-01-20T10:00:00.000Z
> require('chrono-node').parseDate('May 20')
2020-05-20T09:00:00.000Z
> require('chrono-node').parseDate('Sep 20')
2019-09-20T09:00:00.000Z
> require('chrono-node').parseDate('Dec 20')
2019-12-20T10:00:00.000ZWhile explaining issue I found better way:
> require('chrono-node').parseDate('Jan 10', String(new Date().getFullYear()), {forwardDate: true})
So this should be 'default', add this please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.