-
-
Notifications
You must be signed in to change notification settings - Fork 183
Closed
Description
Prerequisites
- I'm using the last version.My node version is the same as declared as
package.json
.To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Subject of the issue
When date is presented omitting year, for example Jun 20. Chrome/NodeJS new Date
will not produce NaN
as it should and will output 2001-06-11T21:00:00.000Z
which is total mess.
while chrono parse it right:
> chrono.parseDate('Jun 12');
2019-06-12T09:00:00.000Z
You can find date in this format here:
https://vicki.substack.com/p/keybase-and-the-chaos-of-crypto
Proposition
completely remove native parsing and use crono as reliable parser:
https://github.com/microlinkhq/metascraper/blob/master/packages/metascraper-helpers/index.js#L201-L202
p.s. I don't know why Date / chrono add 21 and 9 hours to date respectivly, but I think it's negligible if date has no year.
Activity
fix(metascrapper-date): chrono as defalt date parser fix microlinkhq#241
fix(metascrapper-date): chrono as defalt date parser fix microlinkhq#241
fix(metascrapper-date): chrono as defalt date parser fix microlinkhq#241
fix(metascrapper-date): chrono as defalt date parser fix microlinkhq#241
fix(metascrapper-date): chrono as defalt date parser fix microlinkhq#241
fix(metascrapper-date): chrono as defalt date parser fix microlinkhq#241