You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you so much for making this. I've desperately been looking for a NodeJS microformats parser to the point where I considered writing my own since the only other one is quite broken. I really appreciate you taking the time to make this, especially since the demand is somewhat low.
When taking a quick look at the project, I noticed some problems with your package.json.
issue: The author field is malformed.
The current value of Aimee Gamble-Milner <https://github.com/aimee-gm> does not parse correctly, because angle brackets are supposed to be used for the author's email address. (The author's website is enclosed in parentheses).
First of all, thank you so much for making this. I've desperately been looking for a NodeJS microformats parser to the point where I considered writing my own since the only other one is quite broken. I really appreciate you taking the time to make this, especially since the demand is somewhat low.
When taking a quick look at the project, I noticed some problems with your package.json.
issue: The
author
field is malformed.The current value of
Aimee Gamble-Milner <https://github.com/aimee-gm>
does not parse correctly, because angle brackets are supposed to be used for the author's email address. (The author's website is enclosed in parentheses).See also: https://docs.npmjs.com/files/package.json#people-fields-author-contributors
suggestion: Explicitly declare the supported versions of Node using the
engines
property.The CONTRIBUTING file mentions:
Therefore I suggest adding the following to the package.json file (v10 is currently the oldest LTS version):
See also: https://docs.npmjs.com/files/package.json#engines
suggestion: Use the
files
property instead of a.npmignore
file.See also:
The text was updated successfully, but these errors were encountered: